Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailhog: fix build #4488

Closed
wants to merge 3 commits into from
Closed

mailhog: fix build #4488

wants to merge 3 commits into from

Conversation

DomT4
Copy link
Member

@DomT4 DomT4 commented Sep 3, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --new-formula <formula> (after doing brew install <formula>)?

I cannot emphasise enough how reluctant we would be to backport this much from upstream if the existing build wasn't completely broken in several ways. As it happens, it's either this or the boneyard, so let's go with this.

Ref: #2931
Ref: #2501 (comment)

@DomT4 DomT4 added the go Go use is a significant feature of the PR or issue label Sep 3, 2016
@BrewTestBot BrewTestBot added the in progress Stale bot should stay away label Sep 3, 2016
I cannot emphasise enough how reluctant we would be to backport this much
from upstream if the existing build wasn't completely broken in several ways.
As it happens, it's either this or the boneyard, so let's go with this.

Ref: #2931
Ref: #2501 (comment)
@DomT4 DomT4 closed this in 202920b Sep 3, 2016
@BrewTestBot BrewTestBot removed the in progress Stale bot should stay away label Sep 3, 2016
@DomT4 DomT4 deleted the mailhog branch September 3, 2016 22:27
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants