Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IgxCalendar: set weekStart globally #10543

Closed
Timmeeeey opened this issue Nov 18, 2021 · 7 comments · Fixed by #11636 or #11812
Closed

IgxCalendar: set weekStart globally #10543

Timmeeeey opened this issue Nov 18, 2021 · 7 comments · Fixed by #11636 or #11812
Assignees
Labels
✔️ status: approved Status for feature-requests that have been reviewed and approved for implementation. 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@Timmeeeey
Copy link

Is your feature request related to a problem? Please describe.

If you use IgxCalendar or IgxDatePicker the weekStart property has to be set on every component.

Describe the solution you'd like

It would be nice if you could set the weekStart default value somehow globally to avoid code duplication.

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jan 18, 2022
@zdrawku zdrawku removed the status: inactive Used to stale issues and pull requests label Apr 4, 2022
@zdrawku zdrawku self-assigned this Apr 4, 2022
@zdrawku zdrawku reopened this Apr 4, 2022
@Volen99 Volen99 added ✔️ status: approved Status for feature-requests that have been reviewed and approved for implementation. and removed 🆕 status: new labels Apr 21, 2022
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jun 21, 2022
@hanastasov hanastasov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed status: inactive Used to stale issues and pull requests labels Jun 24, 2022
@hanastasov
Copy link
Contributor

Hi @Timmeeeey , with the patch scheduled to be released today for version 14, the requeted feature will be available:

  • ability to set locale and weekStart for IgxDatePicker`, as it has been available for the calendar
  • ability to set weekStart per column for the grid, through the pipeArgs input property
  • if not set, locale will inherit the value of the global application locale
  • if not set, weekStart will be read from current locale

Since to achieve this new props are introduced, change is only introduced in version 14. Is this the version that you are using?

@Timmeeeey
Copy link
Author

Hi @hanastasov, yes I am using version 14.

@hanastasov
Copy link
Contributor

hanastasov commented Jul 1, 2022

@Timmeeeey , the feature is going to roll out with version 14.1, not with minor patch of version 14.0. Sorry for misleading you with my information. Is that ok with you? If you expect that in 14.0 and can't wait for 14.1, just let us know so that we release it with 14.0.

@Timmeeeey
Copy link
Author

@hanastasov Version 14.1 would be ok for me, thanks!

@zdrawku
Copy link
Contributor

zdrawku commented Jul 7, 2022

As we discussed with Hristo, this feature will be available with the 14.0.6 weekly patches release next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️ status: approved Status for feature-requests that have been reviewed and approved for implementation. 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
4 participants