feat(calendar): make weekStart default value to depend on current locale #11458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volen99
added
🧰 feature-request
❌ status: awaiting-test
…com/IgniteUI/igniteui-angular into VDyulgerov/feature-startWeek-locale
hanastasov
added
💥 status: in-test
hanastasov
requested changes
May 18, 2022
There was a problem hiding this comment.
Bugs found:
- Let's set a global
LOCALE_IDfor calendar.sample.html:
@Component({
selector: 'app-calendar-sample',
templateUrl: 'calendar.sample.html',
styleUrls: ['calendar.sample.scss'],
providers: [{provide: LOCALE_ID, useValue: 'fr-FR' }]
})
Result:
Calendar is not displayed per FR locale. This is Story 1 from the spec.- When passing invalid value for locale, then setting
weekStartis not respected:
<igx-date-picker **locale='US'** [weekStart]="5" Result: weekStart is not Friday. Check if same is for grid, date-range picker, etc.
| @@ -258,6 +259,9 @@ export class IgxCalendarBaseDirective implements ControlValueAccessor { | |||
| */ | |||
| public set locale(value: string) { | |||
| this._locale = value; | |||
| if (!this.weekStart) { | |||
There was a problem hiding this comment.
If we have set weekStart to be WEEKDAYS.Sunday (equals 0), this check will always evaluate as true and override the value. Example:
<igx-date-picker locale="FR" [weekStart]="0" weekStart will always be 1, which is the default of french locale.
…com/IgniteUI/igniteui-angular into VDyulgerov/feature-startWeek-locale
…com/IgniteUI/igniteui-angular into VDyulgerov/feature-startWeek-locale
This reverts commit ced5f9e.
…com/IgniteUI/igniteui-angular into VDyulgerov/feature-startWeek-locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10543, #10852
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)