-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V dyulgerov/feature locale 14.0 #11812
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volen99
added
❌ status: awaiting-test
PRs awaiting manual verification
📆 calendar
🧰 feature-request
version: 14.0.x
labels
Jul 4, 2022
zdrawku
added
💥 status: in-test
PRs currently being tested
and removed
❌ status: awaiting-test
PRs awaiting manual verification
labels
Jul 5, 2022
zdrawku
requested changes
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the changes I see a couple of inconsistences compared to the changes that were merged already:
- state.directive.spec.ts fit removal is not eperformed here.
- I see that we've merged a
debugger
with that PR. Please address that and ensure that we didnt merged this debugger into other branches as well (its strange that lint doesnt complained about that) - With the changes against the other branches you are updating the calendar sample, date picker sample, date-range sample and time picker. Somehow these changes are not present here.
Please ensure that you did a proper cherry-pick.
zdrawku
approved these changes
Jul 6, 2022
zdrawku
added
✅ status: verified
Applies to PRs that have passed manual verification
and removed
💥 status: in-test
PRs currently being tested
labels
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📆 calendar
🧰 feature-request
version: 14.0.x
✅ status: verified
Applies to PRs that have passed manual verification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10543, #10852
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)