Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V dyulgerov/feature locale 14.0 #11812

Merged
merged 8 commits into from
Jul 6, 2022
Merged

Conversation

Volen99
Copy link
Contributor

@Volen99 Volen99 commented Jul 4, 2022

Closes #10543, #10852

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@Volen99 Volen99 requested a review from zdrawku July 4, 2022 06:36
@Volen99 Volen99 changed the base branch from master to 14.0.x July 4, 2022 06:36
@zdrawku zdrawku added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 5, 2022
Copy link
Contributor

@zdrawku zdrawku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the changes I see a couple of inconsistences compared to the changes that were merged already:

  • state.directive.spec.ts fit removal is not eperformed here.
  • I see that we've merged a debugger with that PR. Please address that and ensure that we didnt merged this debugger into other branches as well (its strange that lint doesnt complained about that)
  • With the changes against the other branches you are updating the calendar sample, date picker sample, date-range sample and time picker. Somehow these changes are not present here.

Please ensure that you did a proper cherry-pick.

@zdrawku zdrawku added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jul 6, 2022
@zdrawku zdrawku merged commit 87bcd54 into 14.0.x Jul 6, 2022
@zdrawku zdrawku deleted the VDyulgerov/feature-locale-14.0 branch July 6, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IgxCalendar: set weekStart globally
2 participants