Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IgxTimePicker refactoring #6482

Closed
jackofdiamond5 opened this issue Jan 16, 2020 · 4 comments · Fixed by #9160
Closed

IgxTimePicker refactoring #6482

jackofdiamond5 opened this issue Jan 16, 2020 · 4 comments · Fixed by #9160
Assignees
@Lipata @PlamenaMiteva
Labels
📈 enhancement 🕐 time-picker 🛠️ status: in-development Issues and PRs with active development on them program: igniteui project management refactoring ♿ a11y When the issue or PR is related to accessibility

Comments

@jackofdiamond5
Copy link
Member

jackofdiamond5 commented Jan 16, 2020 •
edited by Lipata
Loading

Dependant on #6271

Related to #7199

Specification

Once the new IgxDateTimeEditorDirective is finished, we should refactor the time picker to use the new editor to handle mask parsing, spinning, date validation and any other action related to the time picker's input.

Tasks during refactoring:

  • Inheritance of new base parent - introducing new members, renaming old ones (1 day)
  • Integration of IgxDateTimeEditorDirective (12 days)
    • Code clean up for already existing functionality in the IgxDatePickerComponent
    • Refactoring of model binding
    • Move CalendarContainer to global date directory
  • Use DateTimeUtils
Issues that will be ignored during the refactoring because they could lead to inconsistencies in the product - #6585
@PlamenaMiteva PlamenaMiteva mentioned this issue May 15, 2020
Closed
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jul 15, 2020
@jackofdiamond5 jackofdiamond5 removed the status: inactive Used to stale issues and pull requests label Jul 15, 2020
@jackofdiamond5 jackofdiamond5 mentioned this issue Aug 13, 2020
Closed
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Sep 14, 2020
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Sep 14, 2020
@Lipata Lipata mentioned this issue Oct 1, 2020
Closed
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Nov 14, 2020
@jackofdiamond5 jackofdiamond5 removed the status: inactive Used to stale issues and pull requests label Nov 14, 2020
@jackofdiamond5 jackofdiamond5 mentioned this issue Nov 25, 2020
Closed
@Lipata Lipata added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jan 26, 2021
@radomirchev radomirchev added the program: igniteui project management label Feb 5, 2021
@Lipata Lipata assigned PlamenaMiteva and unassigned Lipata and jackofdiamond5 Feb 8, 2021
PlamenaMiteva added a commit that referenced this issue Feb 10, 2021
@PlamenaMiteva
refactor(time-picker): initial refactoring #6482
e309406
@kdinev kdinev added the ♿ a11y When the issue or PR is related to accessibility label Feb 10, 2021
@Lipata Lipata mentioned this issue Apr 12, 2021
Merged
14 tasks
PlamenaMiteva added a commit that referenced this issue Apr 13, 2021
@PlamenaMiteva
refactor(time-picker): remove spinDelta #6482
677eb48
PlamenaMiteva added a commit that referenced this issue Apr 13, 2021
@PlamenaMiteva
test(time-picker): fix failing tests #6482
f2c8cac
Lipata added a commit that referenced this issue Apr 14, 2021
@Lipata
feat(date-time-editor,pickers): add migrations #6482, #6483
66726e8
PlamenaMiteva added a commit that referenced this issue Apr 14, 2021
@PlamenaMiteva
refactor(time-picker): add aria attributes #6482
304daed
PlamenaMiteva added a commit that referenced this issue Apr 14, 2021
@PlamenaMiteva
refactor(time-picker): fix lint errors #6482
6e0ec31
PlamenaMiteva added a commit that referenced this issue Apr 14, 2021
@PlamenaMiteva
refactor(time-picker): fix lint errors #6482
7e3c840
PlamenaMiteva added a commit that referenced this issue Apr 15, 2021
@PlamenaMiteva
refactor(time-picker): addressing comments #6482
77d7e28
PlamenaMiteva added a commit that referenced this issue Apr 15, 2021
@PlamenaMiteva
refactor(time-picker): include platformUtil #6482
9a95535
PlamenaMiteva added a commit that referenced this issue Apr 16, 2021
@PlamenaMiteva
refactor(time-picker): addressing comments #6482
ef058be
PlamenaMiteva added a commit that referenced this issue Apr 16, 2021
@PlamenaMiteva
refactor(time-picker): fix lint errors #6482
c82f73c
PlamenaMiteva added a commit that referenced this issue Apr 16, 2021
@PlamenaMiteva
refactor(time-picker): fix failing tests #6482
fad482d
PlamenaMiteva added a commit that referenced this issue Apr 18, 2021
@PlamenaMiteva
refactor(time-picker): add aria attributes to selected items #6482
ae279d8
PlamenaMiteva added a commit that referenced this issue Apr 19, 2021
@PlamenaMiteva
refactor(time-picker): revert tabs component #6482
7dc7fbd
PlamenaMiteva added a commit that referenced this issue Apr 19, 2021
@PlamenaMiteva
refactor(time-picker): remove fontSet #6482
304a0a3
PlamenaMiteva added a commit that referenced this issue Apr 19, 2021
@PlamenaMiteva
refactor(time-picker): add readOnly property #6482
8e24a34
PlamenaMiteva added a commit that referenced this issue Apr 19, 2021
@PlamenaMiteva
refactor(time-picker): fix time picker settings in grid templates #6482
7185716
PlamenaMiteva added a commit that referenced this issue Apr 19, 2021
@PlamenaMiteva
refactor(time-picker): fix typos #6482
f19b98b
PlamenaMiteva added a commit that referenced this issue Apr 19, 2021
@PlamenaMiteva
refactor(time-picker): addressing comments #6482
4c1ef00
PlamenaMiteva added a commit that referenced this issue Apr 19, 2021
@PlamenaMiteva
refactor(time-picker): remove unnecessary event subscription #6482
1b5c9ab
PlamenaMiteva added a commit that referenced this issue Apr 19, 2021
@PlamenaMiteva
refactor(time-picker): add HostListner on keydown event #6482
8e25f92
PlamenaMiteva added a commit that referenced this issue Apr 19, 2021
@PlamenaMiteva
chore(time-picker): fix typos #6482
fa790a6
PlamenaMiteva added a commit that referenced this issue Apr 19, 2021
@PlamenaMiteva
chore(time-picker): move host listener up #6482
92d3351
Lipata pushed a commit that referenced this issue Apr 19, 2021
@PlamenaMiteva @jackofdiamond5
feat(igx-time-picker): refactoring #6482 (#8947)
b2b1758 
Co-authored-by: Boris Penkov <jackofdiamond596@gmail.com>
Lipata added a commit that referenced this issue Apr 19, 2021
@Lipata @jackofdiamond5 @PlamenaMiteva
feat(date-time-editor, pickers): add migrations, changelog, readme #6482
63a54eb 
, #6483 (#9319)

Co-authored-by: Boris <jackofdiamond596@gmail.com>
Co-authored-by: plamenamiteva <plamenamiteva@abv.bg>
PlamenaMiteva added a commit that referenced this issue Apr 20, 2021
@PlamenaMiteva
test(time-picker): fix failing tests #6482
de16797
PlamenaMiteva added a commit that referenced this issue Apr 20, 2021
@PlamenaMiteva
test(time-picker): fix failing test #6482
9370ece
Lipata pushed a commit that referenced this issue Apr 21, 2021
@jackofdiamond5 @PlamenaMiteva
refactor(date-picker, time-picker): date-time-editor integration #6482 …
403acdc 
…#6483 (#9160)

* feat(*): add PickersBaseDirective

* feat(date-time-editor): handling for wheel events

* feat(types): add new enum HeaderOrientation

* feat(date-time-editor): add preventSpeenOnWheel input

* feat(date-time-editor): can be set to suppress focus

* feat(DatePickerUtils): add method for min/max validation

* refactor(CalendarContainer): move to date-utils

* feat(PickersBaseDirective): implements EditorProvider

* refactor(picker-icons): move picker icon components to date-common

* feat(date-time-editor): add option to set spin delta per part #7169 (#8987)

* refactor(date-range): pickers base, overlay service, template buttons, valueChange

* refactor(date-editor): rename isSpinLoop to spinLoop

* feat(date-time-editor, date-range-picker, date-picker): ISO 8601 support #6994

* feat(date-picker): add readonly prop, close on escape

* refactor(advanced-filtering): update date picker template

* refactor(filtering-row): update date picker template

* refactor(excel-style-date-expr): update date picker template

* refactor(input-directive):  set disabled using hostbinding

* feat(igx-time-picker): refactoring #6482 (#8947)

* feat(date-time-editor, pickers): add migrations, changelog, readme #6482, #6483 (#9319)

Co-authored-by: Boris <jackofdiamond596@gmail.com>
Co-authored-by: plamenamiteva <plamenamiteva@abv.bg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@PlamenaMiteva PlamenaMiteva

Labels
📈 enhancement 🕐 time-picker 🛠️ status: in-development Issues and PRs with active development on them program: igniteui project management refactoring ♿ a11y When the issue or PR is related to accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pickers refactoring IgniteUI/igniteui-angular
5 participants
@kdinev @Lipata @PlamenaMiteva @jackofdiamond5 @radomirchev