IgxTimePicker refactoring #8947

PlamenaMiteva · 2021-02-10T08:01:03Z

Additional information (check all that apply):

Checklist:

All relevant tags have been applied to this PR
This PR includes unit tests covering all the new code (test guidelines)
This PR includes API docs for newly added methods/properties (api docs guidelines)
This PR includes feature/README.MD updates for the feature docs
This PR includes general feature table updates in the root README.MD
This PR includes CHANGELOG.MD updates for newly added functionality
This PR contains breaking changes
This PR includes ng update migrations for the breaking changes (migrations guidelines)
This PR includes behavioral changes and the feature specification has been updated with them

…iteui-angular into PMiteva/time-picker-refactoring # Conflicts: # projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts

…ing #6482

…IgniteUI/igniteui-angular into PMiteva/time-picker-refactoring

projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts

projects/igniteui-angular/src/lib/directives/date-time-editor/date-time-editor.directive.ts

projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts

projects/igniteui-angular/src/lib/time-picker/time-picker.pipes.ts

…iteui-angular into PMiteva/time-picker-refactoring

…onent.ts Co-authored-by: Boris Penkov <jackofdiamond596@gmail.com>

…IgniteUI/igniteui-angular into PMiteva/time-picker-refactoring

…iteui-angular into PMiteva/time-picker-refactoring # Conflicts: # projects/igniteui-angular/src/lib/date-common/pickers-base.directive.ts

…iteui-angular into PMiteva/time-picker-refactoring # Conflicts: # projects/igniteui-angular/src/lib/date-common/picker-base.directive.ts # projects/igniteui-angular/src/lib/date-picker/date-picker.utils.ts # projects/igniteui-angular/src/lib/time-picker/time-picker.common.ts # projects/igniteui-angular/src/lib/time-picker/time-picker.component.spec.ts # projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts # projects/igniteui-angular/src/lib/time-picker/time-picker.directives.ts # src/app/time-picker/time-picker.sample.ts

…IgniteUI/igniteui-angular into PMiteva/time-picker-refactoring # Conflicts: # projects/igniteui-angular/src/lib/date-common/picker-base.directive.ts

…IgniteUI/igniteui-angular into PMiteva/time-picker-refactoring

damyanpetev · 2021-04-15T06:44:48Z

projects/igniteui-angular/src/lib/date-common/util/date-time.util.ts

@@ -359,6 +360,7 @@ export abstract class DateTimeUtil {
            const format = timePart.replace(/\d/g, '0');
            timePart = new MaskParsingService().replaceInMask(timePart, value,
                { format, promptChar: '' }, 0, value.length).value;
+            timePart = timePart.substr(0, timePart.length - 1);


Yeah, taking everything except the last char won't work in too many scenarios - time portion has zone different than UTC (+00) or no zone at all in which case you'd be removing from the milliseconds most likely. What's more, I don't see the need to remove parts of the value or go as far as the mask parsing for this - you already have a date-only part, perhaps just combining it with the literal and the time portion will produce a valid date string?

Also, might want to add some invalid date checks to this parse method, unless the consuming locations are supposed to check for that. The return type is described as Date | null but I don't see how the latter is possible in the current code

projects/igniteui-angular/src/lib/date-common/util/date-time.util.ts

projects/igniteui-angular/src/lib/date-picker/date-picker.utils.ts

projects/igniteui-angular/src/lib/directives/date-time-editor/date-time-editor.directive.ts

projects/igniteui-angular/src/lib/time-picker/time-picker.common.ts

projects/igniteui-angular/src/lib/time-picker/time-picker.component.html

…IgniteUI/igniteui-angular into PMiteva/time-picker-refactoring

projects/igniteui-angular/src/lib/time-picker/time-picker.component.html

…iteui-angular into PMiteva/time-picker-refactoring

projects/igniteui-angular/src/lib/time-picker/time-picker.component.html

damyanpetev · 2021-04-19T08:56:04Z

projects/igniteui-angular/src/lib/time-picker/time-picker.component.html

+                    [attr.role]="timeItem.isSelectedTime ? 'spinbutton' : null"
+                    [attr.aria-valuenow]="timeItem.isSelectedTime ? timeItem.hourValue : null"
+                    [attr.aria-valuemin]="timeItem.isSelectedTime ? timeItem.minValue : null"
+                    [attr.aria-valuemax]="timeItem.isSelectedTime ? timeItem.maxValue : null"


Since the time item is apparently aware if it's selected, these can all be host bound in the directive instead to reduce the amount of repetition in this template

projects/igniteui-angular/src/lib/grids/cell.component.html

...-angular/src/lib/grids/filtering/advanced-filtering/advanced-filtering-dialog.component.html

projects/igniteui-angular/src/lib/time-picker/time-picker.directives.ts

projects/igniteui-angular/src/lib/time-picker/time-picker.pipes.ts

projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts

damyanpetev · 2021-04-19T12:10:05Z

projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts

     */
    @Input()
-    public disabled = false;
+    public displayFormat: string;


Technically, that's inherited already, though just for the documentation it might be okay to keep. Same with a few others.

…#6483 (#9160) * feat(*): add PickersBaseDirective * feat(date-time-editor): handling for wheel events * feat(types): add new enum HeaderOrientation * feat(date-time-editor): add preventSpeenOnWheel input * feat(date-time-editor): can be set to suppress focus * feat(DatePickerUtils): add method for min/max validation * refactor(CalendarContainer): move to date-utils * feat(PickersBaseDirective): implements EditorProvider * refactor(picker-icons): move picker icon components to date-common * feat(date-time-editor): add option to set spin delta per part #7169 (#8987) * refactor(date-range): pickers base, overlay service, template buttons, valueChange * refactor(date-editor): rename isSpinLoop to spinLoop * feat(date-time-editor, date-range-picker, date-picker): ISO 8601 support #6994 * feat(date-picker): add readonly prop, close on escape * refactor(advanced-filtering): update date picker template * refactor(filtering-row): update date picker template * refactor(excel-style-date-expr): update date picker template * refactor(input-directive): set disabled using hostbinding * feat(igx-time-picker): refactoring #6482 (#8947) * feat(date-time-editor, pickers): add migrations, changelog, readme #6482, #6483 (#9319) Co-authored-by: Boris <jackofdiamond596@gmail.com> Co-authored-by: plamenamiteva <plamenamiteva@abv.bg>

PlamenaMiteva added 2 commits February 10, 2021 08:56

refactor(time-picker): initial refactoring #6482

e309406

Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…

0dd4ae4

…iteui-angular into PMiteva/time-picker-refactoring # Conflicts: # projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts

PlamenaMiteva added refactoring 🕐 time-picker labels Feb 10, 2021

PlamenaMiteva added 8 commits February 10, 2021 11:29

refactor(time-picker): add dialog orientaation #6482

0c5adc9

refactor(time-picker): in/decrement and spinning refactoring #6482

54b14e0

Merge branch 'pickers-refactoring' into PMiteva/time-picker-refactoring

b7acbac

refactor(time-picker): valueChange & validationFailed events refactor…

a02af40

…ing #6482

Merge branch 'PMiteva/time-picker-refactoring' of https://github.com/…

1c80641

…IgniteUI/igniteui-angular into PMiteva/time-picker-refactoring

chore(time-picker): fix typo in package-lock.json

6dc5451

refactor(time-picker): add validation refactoring #6482

6f5ef51

refactor(time-picker): fix dialog header format #6482

d75263b

jackofdiamond5 requested changes Feb 23, 2021

View reviewed changes

PlamenaMiteva and others added 4 commits February 26, 2021 15:57

refactor(time-picker): refactoring tests #6482

9c34e2a

Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…

575b01c

…iteui-angular into PMiteva/time-picker-refactoring

Update projects/igniteui-angular/src/lib/time-picker/time-picker.comp…

43f4222

…onent.ts Co-authored-by: Boris Penkov <jackofdiamond596@gmail.com>

Update projects/igniteui-angular/src/lib/time-picker/time-picker.comp…

efa390b

…onent.ts Co-authored-by: Boris Penkov <jackofdiamond596@gmail.com>

jackofdiamond5 force-pushed the pickers-refactoring branch from 7e2c752 to 8e2ef17 Compare March 10, 2021 13:02

PlamenaMiteva added 3 commits March 11, 2021 17:22

refactor(time-picker): addressing comments #6482

c154bb6

Merge branch 'PMiteva/time-picker-refactoring' of https://github.com/…

f93a9c9

…IgniteUI/igniteui-angular into PMiteva/time-picker-refactoring

Merge branch 'pickers-refactoring' into PMiteva/time-picker-refactoring

633bb0c

jackofdiamond5 mentioned this pull request Mar 12, 2021

DatePickerUtil refactoring #9135

Merged

14 tasks

PlamenaMiteva added 8 commits April 2, 2021 11:52

Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…

f116c9b

…iteui-angular into PMiteva/time-picker-refactoring # Conflicts: # projects/igniteui-angular/src/lib/date-common/pickers-base.directive.ts

refactor(time-picker): add time pipe #6482

c4d528f

refactor(time-picker): container refactoring #6482

f28fda0

Merge branch 'PMiteva/time-picker-refactoring' of https://github.com/…

eab163d

…IgniteUI/igniteui-angular into PMiteva/time-picker-refactoring # Conflicts: # projects/igniteui-angular/src/lib/date-common/picker-base.directive.ts

refactor(time-picker): incorporate ISO format implementation #6482

e155b2e

refactor(time-picker): add input/display format validation #6482

384818f

refactor(time-picker): add input/display format validation #6482

0a0e710

Merge branch 'PMiteva/time-picker-refactoring' of https://github.com/…

2071cc1

…IgniteUI/igniteui-angular into PMiteva/time-picker-refactoring

damyanpetev reviewed Apr 15, 2021

View reviewed changes

Lipata added the squash-merge Merge PR with "Squash and Merge" option label Apr 15, 2021

PlamenaMiteva added 4 commits April 15, 2021 16:52

Merge branch 'pickers-refactoring' into PMiteva/time-picker-refactoring

d233a17

refactor(time-picker): addressing comments #6482

77d7e28

Merge branch 'PMiteva/time-picker-refactoring' of https://github.com/…

c397f18

…IgniteUI/igniteui-angular into PMiteva/time-picker-refactoring

refactor(time-picker): include platformUtil #6482

9a95535

damyanpetev reviewed Apr 16, 2021

View reviewed changes

projects/igniteui-angular/src/lib/time-picker/time-picker.component.html Outdated Show resolved Hide resolved

PlamenaMiteva added 11 commits April 16, 2021 18:35

refactor(time-picker): addressing comments #6482

ef058be

refactor(time-picker): fix lint errors #6482

c82f73c

refactor(time-picker): fix failing tests #6482

fad482d

refactor(time-picker): add aria attributes to selected items #6482

ae279d8

refactor(time-picker): revert tabs component #6482

7dc7fbd

Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…

fbdaa1a

…iteui-angular into PMiteva/time-picker-refactoring

refactor(time-picker): remove fontSet #6482

304a0a3

Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…

ac685cb

…iteui-angular into PMiteva/time-picker-refactoring

refactor(time-picker): add readOnly property #6482

8e24a34

refactor(time-picker): fix time picker settings in grid templates #6482

7185716

refactor(time-picker): fix typos #6482

f19b98b

damyanpetev reviewed Apr 19, 2021

View reviewed changes

PlamenaMiteva added 5 commits April 19, 2021 16:04

refactor(time-picker): addressing comments #6482

4c1ef00

refactor(time-picker): remove unnecessary event subscription #6482

1b5c9ab

refactor(time-picker): add HostListner on keydown event #6482

8e25f92

chore(time-picker): fix typos #6482

fa790a6

chore(time-picker): move host listener up #6482

92d3351

damyanpetev approved these changes Apr 19, 2021

View reviewed changes

jackofdiamond5 approved these changes Apr 19, 2021

View reviewed changes

Lipata merged commit b2b1758 into pickers-refactoring Apr 19, 2021

Lipata deleted the PMiteva/time-picker-refactoring branch April 19, 2021 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IgxTimePicker refactoring #8947

IgxTimePicker refactoring #8947

PlamenaMiteva commented Feb 10, 2021 •

edited by Lipata

Loading

damyanpetev Apr 15, 2021

damyanpetev Apr 15, 2021

damyanpetev Apr 19, 2021

damyanpetev Apr 19, 2021

IgxTimePicker refactoring #8947

IgxTimePicker refactoring #8947

Conversation

PlamenaMiteva commented Feb 10, 2021 • edited by Lipata Loading

Additional information (check all that apply):

Checklist:

damyanpetev Apr 15, 2021

Choose a reason for hiding this comment

damyanpetev Apr 15, 2021

Choose a reason for hiding this comment

damyanpetev Apr 19, 2021

Choose a reason for hiding this comment

damyanpetev Apr 19, 2021

Choose a reason for hiding this comment

PlamenaMiteva commented Feb 10, 2021 •

edited by Lipata

Loading