-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IgxTimePicker refactoring #8947
Merged
Merged
Changes from 33 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
e309406
refactor(time-picker): initial refactoring #6482
PlamenaMiteva 0dd4ae4
Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…
PlamenaMiteva 0c5adc9
refactor(time-picker): add dialog orientaation #6482
PlamenaMiteva 54b14e0
refactor(time-picker): in/decrement and spinning refactoring #6482
PlamenaMiteva b7acbac
Merge branch 'pickers-refactoring' into PMiteva/time-picker-refactoring
PlamenaMiteva a02af40
refactor(time-picker): valueChange & validationFailed events refactor…
PlamenaMiteva 1c80641
Merge branch 'PMiteva/time-picker-refactoring' of https://github.com/…
PlamenaMiteva 6dc5451
chore(time-picker): fix typo in package-lock.json
PlamenaMiteva 6f5ef51
refactor(time-picker): add validation refactoring #6482
PlamenaMiteva d75263b
refactor(time-picker): fix dialog header format #6482
PlamenaMiteva 9c34e2a
refactor(time-picker): refactoring tests #6482
PlamenaMiteva 575b01c
Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…
PlamenaMiteva 43f4222
Update projects/igniteui-angular/src/lib/time-picker/time-picker.comp…
PlamenaMiteva efa390b
Update projects/igniteui-angular/src/lib/time-picker/time-picker.comp…
PlamenaMiteva c154bb6
refactor(time-picker): addressing comments #6482
PlamenaMiteva f93a9c9
Merge branch 'PMiteva/time-picker-refactoring' of https://github.com/…
PlamenaMiteva 633bb0c
Merge branch 'pickers-refactoring' into PMiteva/time-picker-refactoring
PlamenaMiteva f116c9b
Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…
PlamenaMiteva c4d528f
refactor(time-picker): add time pipe #6482
PlamenaMiteva f28fda0
refactor(time-picker): container refactoring #6482
PlamenaMiteva be97844
Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…
PlamenaMiteva eab163d
Merge branch 'PMiteva/time-picker-refactoring' of https://github.com/…
PlamenaMiteva e155b2e
refactor(time-picker): incorporate ISO format implementation #6482
PlamenaMiteva 384818f
refactor(time-picker): add input/display format validation #6482
PlamenaMiteva 0a0e710
refactor(time-picker): add input/display format validation #6482
PlamenaMiteva 1e40a76
Merge branch 'PMiteva/time-picker-refactoring' of https://github.com/…
PlamenaMiteva e9794ec
refactor(time-picker): fix typos #6482
PlamenaMiteva 677eb48
refactor(time-picker): remove spinDelta #6482
PlamenaMiteva f2c8cac
test(time-picker): fix failing tests #6482
PlamenaMiteva 304daed
refactor(time-picker): add aria attributes #6482
PlamenaMiteva 6e0ec31
refactor(time-picker): fix lint errors #6482
PlamenaMiteva 7e3c840
refactor(time-picker): fix lint errors #6482
PlamenaMiteva 2071cc1
Merge branch 'PMiteva/time-picker-refactoring' of https://github.com/…
PlamenaMiteva d233a17
Merge branch 'pickers-refactoring' into PMiteva/time-picker-refactoring
PlamenaMiteva 77d7e28
refactor(time-picker): addressing comments #6482
PlamenaMiteva c397f18
Merge branch 'PMiteva/time-picker-refactoring' of https://github.com/…
PlamenaMiteva 9a95535
refactor(time-picker): include platformUtil #6482
PlamenaMiteva ef058be
refactor(time-picker): addressing comments #6482
PlamenaMiteva c82f73c
refactor(time-picker): fix lint errors #6482
PlamenaMiteva fad482d
refactor(time-picker): fix failing tests #6482
PlamenaMiteva ae279d8
refactor(time-picker): add aria attributes to selected items #6482
PlamenaMiteva 7dc7fbd
refactor(time-picker): revert tabs component #6482
PlamenaMiteva fbdaa1a
Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…
PlamenaMiteva 304a0a3
refactor(time-picker): remove fontSet #6482
PlamenaMiteva ac685cb
Merge branch 'pickers-refactoring' of https://github.com/IgniteUI/ign…
PlamenaMiteva 8e24a34
refactor(time-picker): add readOnly property #6482
PlamenaMiteva 7185716
refactor(time-picker): fix time picker settings in grid templates #6482
PlamenaMiteva f19b98b
refactor(time-picker): fix typos #6482
PlamenaMiteva 4c1ef00
refactor(time-picker): addressing comments #6482
PlamenaMiteva 1b5c9ab
refactor(time-picker): remove unnecessary event subscription #6482
PlamenaMiteva 8e25f92
refactor(time-picker): add HostListner on keydown event #6482
PlamenaMiteva fa790a6
chore(time-picker): fix typos #6482
PlamenaMiteva 92d3351
chore(time-picker): move host listener up #6482
PlamenaMiteva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, taking everything except the last char won't work in too many scenarios - time portion has zone different than UTC (+00) or no zone at all in which case you'd be removing from the milliseconds most likely. What's more, I don't see the need to remove parts of the value or go as far as the mask parsing for this - you already have a date-only part, perhaps just combining it with the literal and the time portion will produce a valid date string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, might want to add some invalid date checks to this parse method, unless the consuming locations are supposed to check for that. The return type is described as
Date | null
but I don't see how the latter is possible in the current code