DatePickerUtil refactoring #9135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename to DateTimeUtil
jackofdiamond5
added
❌ status: awaiting-test
damyanpetev
reviewed
Mar 19, 2021
projects/igniteui-angular/src/lib/date-common/util/date-time.util.spec.ts
Outdated
Show resolved
Hide resolved
| @@ -652,7 +652,7 @@ export class IgxDateRangePickerComponent extends PickersBaseDirective | |||
| /** @hidden @internal */ | |||
| public ngOnChanges(changes: SimpleChanges): void { | |||
| if (changes['locale']) { | |||
| this.inputFormat = DatePickerUtil.getDefaultInputFormat(this.locale || 'en') || DatePickerUtil.DEFAULT_INPUT_FORMAT; | |||
| this.inputFormat = DateTimeUtil.getDefaultInputFormat(this.locale) || DateTimeUtil.DEFAULT_INPUT_FORMAT; | |||
There was a problem hiding this comment.
Doesn't look like getDefaultInputFormat would return a falsy value in any case, so not sure about the fallback to the default input. Also the util falls back to a different default format for some reason?
Also also (!) - setting the input format public prop like this can be destructive if it's already specified by the user.
| @@ -359,15 +357,15 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh | |||
| return { value: true }; | |||
| } | |||
|
|
|||
| const maxValueAsDate = this.isDate(this.maxValue) ? this.maxValue : this.parseDate(this.maxValue); | |||
| const minValueAsDate = this.isDate(this.minValue) ? this.minValue : this.parseDate(this.minValue); | |||
| const maxValueAsDate = isDate(this.maxValue) ? this.maxValue : this.parseDate(this.maxValue); | |||
There was a problem hiding this comment.
I realize this hasn't changed, but there's an edge case w/ invalid date that'd fail here, since both options aren't equipped to handle it.
projects/igniteui-angular/src/lib/date-common/util/date-time.util.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-common/util/date-time.util.ts
Outdated
Show resolved
Hide resolved
damyanpetev
approved these changes
Mar 19, 2021
damyanpetev
added
squash-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8939, #8947
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)