Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Search with Row Pinning #7192

Merged
merged 60 commits into from
May 8, 2020
Merged

Fix Search with Row Pinning #7192

merged 60 commits into from
May 8, 2020

Conversation

3phase
Copy link
Contributor

@3phase 3phase commented Apr 23, 2020

Related issue: #7161

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@ChronosSF ChronosSF added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 23, 2020
@3phase 3phase added ❌ do not merge 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Apr 24, 2020
@ChronosSF ChronosSF self-requested a review April 27, 2020 07:37
@MayaKirova
Copy link
Contributor

@3phase Also the ChangeLog should be updated with the new Input for the highlight directive and a test for that new input should be added.

@3phase 3phase requested a review from DiyanDimitrov May 4, 2020 09:19
DiyanDimitrov
DiyanDimitrov previously approved these changes May 4, 2020
@skrustev skrustev added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels May 5, 2020
@skrustev
Copy link
Member

skrustev commented May 7, 2020

  • When there is paging and pinning is set to bottom items do not highlight that are in the unpinned area and are not on page 1.

    Steps:

    1. Pin a row when pinning is to bottom
    2. Search for an item that is on page different from the first.
      Result: The search scrolls to the item but it is not highlighted

@3phase
Copy link
Contributor Author

3phase commented May 7, 2020

  • When there is paging and pinning is set to bottom items do not highlight that are in the unpinned area and are not on page 1.
    Steps:

    1. Pin a row when pinning is to bottom
    2. Search for an item that is on page different from the first.
      Result: The search scrolls to the item but it is not highlighted

@skrustev, thanks for remarking that issue, I think it's resolved now.

@3phase 3phase requested a review from DiyanDimitrov May 7, 2020 15:27
@skrustev skrustev added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels May 7, 2020
@skrustev skrustev added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ✅ status: verified Applies to PRs that have passed manual verification 💥 status: in-test PRs currently being tested labels May 7, 2020
@ChronosSF ChronosSF merged commit 49489a0 into master May 8, 2020
@ChronosSF ChronosSF deleted the pbozhinov/fix-rp-search branch May 8, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants