Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RowPinning): Initial implementation of jump to disabled row grid action. #7255

Merged
merged 24 commits into from
May 13, 2020

Conversation

skrustev
Copy link
Member

@skrustev skrustev commented May 4, 2020

#6941

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@MayaKirova
Copy link
Contributor

@skrustev Build fails with error:
Property '_pinnedRecordIDs' does not exist on type 'IgxGridBaseDirective'

Additionally pinning throws error in treegrid:
Cannot set property 'ghostIndex' of undefined

@MayaKirova MayaKirova added 💥 status: in-test PRs currently being tested and removed 🛠️ status: in-development Issues and PRs with active development on them labels May 4, 2020
@MayaKirova
Copy link
Contributor

MayaKirova commented May 4, 2020

Issues:

  • Pinned rows order is not retained correctly in TreeGrid.
    To reproduce pin the second row in tree grid and then the first row. Order in pinned area should be second row and then first row since this is the order of pinning.
  • Jump to + Paging - Not sure what the expected behavior is, but at the moment if the result is on another page the button is shown but clicking it does nothing. It should either change the page to show the result or the button should not be shown if the result cannot be scrolled (is on another page).
  • Jump to + Group by - If the target ghost row is in a collapsed group, the button scrolls to an incorrect index. It should either scroll to the group or preferable it should also expand it to show the ghost row.
  • Jump to + Tree Grid - Same as with grouping. If the target is in a collapsed parent it cannot be scrolled to.

@ChronosSF ChronosSF added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels May 5, 2020
@skrustev skrustev added squash-merge Merge PR with "Squash and Merge" option ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels May 5, 2020
@skrustev
Copy link
Member Author

skrustev commented May 5, 2020

This PR should be merged after #7192, since it contains changes that are required for the Tree Grid Jump To on another page to work.

@skrustev skrustev requested a review from MayaKirova May 8, 2020 08:14
@MayaKirova MayaKirova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels May 8, 2020
@MayaKirova
Copy link
Contributor

MayaKirova commented May 8, 2020

Grid:

  • Grid+ Paging - In Grid if you go from a page that has no scrollbar to a target row on a page with scrollbar the row is not scrolled in view.

Steps to reproduce:

  1. In the gridRowPinning sample in the grid set page size to 5.
  2. Pin the last row and expand a row above it.
  3. Go to the last page and use the "Go to" button.
    Page is changed but the row is not scrolled in view.

Hierarchical Grid:

  • In root grid if a row in the middle is pinned and all rows are then expanded, "Go To" cannot scroll to the correct row.

Steps to reproduce:

  1. In the gridRowPinning sample in the hierarchical grid, pin a row in the middle (8).
  2. Expand all rows via the header button and use the "Go To" button.
  • (This will be logged as limitation.) When using "Go to" in a child grid and target row is not visible in parent, the parent is not scrolled so that the target is visible.

Steps to reproduce:

  1. In the gridRowPinning sample in the hierarchical grid, expand the first row.
  2. Pin the last row in the child grid and scroll both child and parent to the top.
  3. Use the "Go to" button in the pinned row.
    Child is scrolled down, but parent is not, so the target is not visible. User has to scroll the parent down to see the target.

@MayaKirova MayaKirova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels May 11, 2020
@ChronosSF ChronosSF requested a review from dkamburov May 12, 2020 11:42
dkamburov
dkamburov previously approved these changes May 12, 2020
@ChronosSF ChronosSF merged commit 9ac7b4a into master May 13, 2020
@ChronosSF ChronosSF deleted the action-strip-jump-to branch May 13, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: row-pinning squash-merge Merge PR with "Squash and Merge" option version: 9.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants