Adding YUY to RGB capabilities to public API as a processing block. #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should simplify using the camera in less demanding YUY mode, and only converting to RGB what is actually needed. Another important usage of this is recording YUY to ROS-bag for later offline conversion. This can save 33%-50% in file size.
aangerma
reviewed
Jan 14, 2019
src/proc/yuy2rgb.cpp
Outdated
| { | ||
| yuy2rgb::yuy2rgb() | ||
| { | ||
|
|
There was a problem hiding this comment.
I don't see where you initialize _stream_filter
aangerma
reviewed
Jan 14, 2019
| yuy_decoder() : filter(init(), 1) { } | ||
|
|
||
| protected: | ||
| yuy_decoder(std::shared_ptr<rs2_processing_block> block) : filter(block, 1) {} |
There was a problem hiding this comment.
I am not sure what is the purpose of this ctor, is it to enable to user to move other processing block?
There was a problem hiding this comment.
If I implement derived yuy2rgb, the new yuy_decoder wrapper in hpp will need to derive from yuy_decoder. This means it will need to initialize base (yuy_decoder) but pass its own processing block into filter.
aangerma
reviewed
Jan 14, 2019
src/proc/yuy2rgb.cpp
Outdated
| if (f.get_profile().get() != _source_stream_profile.get()) | ||
| { | ||
| _source_stream_profile = f.get_profile(); | ||
| _target_stream_profile = f.get_profile().clone(RS2_STREAM_DEPTH, 0, RS2_FORMAT_RGB8); |
ev-mp
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should simplify using the camera in less demanding YUY mode,
and only converting to RGB what is actually needed.
Another important usage of this is recording YUY to ROS-bag for later
offline conversion. This can save 33%-50% in file size.
TODO: Allow format customization in constructor or via option.