Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Islandora using its drupal namespace. #34

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Oct 19, 2023

What does this Pull Request do?

Solves the duplicate namespace problem encountered when Islandora Starter Site requires drupal/islandora but this repo requires islandora/islandora

What's new?

Changes namespace of required islandora module from islandora to drupal.

How should this be tested?

Load the Starter site. Use composer show to see that you have both islandora/islandora_mirador and drupal/islandora_mirador competing to write code to the same folder.

When requiring this version of Mirador, you should no longer have islandora/islandora but instead only drupal/islandora.

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? no
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag @alxp

@alxp alxp merged commit 04fa440 into Islandora:2.x Nov 9, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants