Add an integrity check to ensure that a url has a correct protocol, i…

…mplements #358

CHANGELOG.md

@@ -14,6 +14,7 @@ to [sourceforge feature requests](https://sourceforge.net/p/jabref/features/) by
 
 ### Changed
 - All import/open database warnings are now shown in a scrolling text area
+- Add an integrity check to ensure that a url has a correct protocol, implements #358
 
 ### Fixed
 - Changes in customized entry types are now directly reflected in the table when clicking "Apply" or "OK"

src/main/java/net/sf/jabref/logic/integrity/IntegrityCheck.java

@@ -19,6 +19,7 @@ public class IntegrityCheck {
     public static final Checker TITLE_CHECKER = new TitleChecker();
     public static final Checker BRACKET_CHECKER = new BracketChecker();
     public static final Checker PAGES_CHECKER = new PagesChecker();
+    public static final Checker URL_CHECKER = new UrlChecker();
 
     public List<IntegrityMessage> checkBibtexDatabase(BibDatabase base) {
         List<IntegrityMessage> result = new ArrayList<>();
@@ -69,6 +70,11 @@ public List<IntegrityMessage> checkBibtexEntry(BibEntry entry) {
             PAGES_CHECKER.check(data.toString(), "pages", entry, result);
         }
 
+        data = entry.getField("url");
+        if (data != null) {
+            URL_CHECKER.check(data.toString(), "url", entry, result);
+        }
+
         return result;
     }
 
@@ -77,6 +83,16 @@ public interface Checker {
         void check(String value, String fieldName, BibEntry entry, List<IntegrityMessage> collector);
     }
 
+    private static class UrlChecker implements Checker {
+
+        @Override
+        public void check(String value, String fieldName, BibEntry entry, List<IntegrityMessage> collector) {
+            if(!value.contains("://")) {
+                collector.add(new IntegrityMessage(Localization.lang("should contain a protocol") + ": http[s]://, file:// or ftp://", entry, fieldName));
+            }
+        }
+    }
+
     private static class AuthorNameChecker implements Checker {
 
         @Override

src/main/resources/l10n/JabRef_da.properties

@@ -1728,3 +1728,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_de.properties

@@ -2437,3 +2437,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=Problem_beim_Analysieren_des_von_IEEEXplore_empfangenen_Eintrags
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_en.properties

@@ -2424,3 +2424,4 @@ Switch_preview_layout=Switch_preview_layout
 Synchronize_files=Synchronize_files
 Unabbreviate=Unabbreviate
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=Error_occured_parsing_Bibtex_returned_from_IEEEXplore
+should_contain_a_protocol=should_contain_a_protocol

src/main/resources/l10n/JabRef_es.properties

@@ -1628,3 +1628,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_fa.properties

@@ -2415,3 +2415,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_fr.properties

@@ -1667,3 +1667,5 @@ Synchronize_files=Synchroniser_les_fichiers
 Unabbreviate=Dés-abréger
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_in.properties

@@ -1648,3 +1648,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_it.properties

@@ -1746,3 +1746,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_ja.properties

@@ -2420,3 +2420,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_nl.properties

@@ -2422,3 +2422,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_no.properties

@@ -2821,3 +2821,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_pt_BR.properties

@@ -1641,3 +1641,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_ru.properties

@@ -2421,3 +2421,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_tr.properties

@@ -1662,3 +1662,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_vi.properties

@@ -2419,3 +2419,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/main/resources/l10n/JabRef_zh.properties

@@ -2416,3 +2416,5 @@ Synchronize_files=
 Unabbreviate=
 
 Error_occured_parsing_Bibtex_returned_from_IEEEXplore=
+
+should_contain_a_protocol=

src/test/java/net/sf/jabref/logic/integrity/IntegrityCheckTest.java

@@ -13,6 +13,16 @@
 
 public class IntegrityCheckTest {
 
+    @Test
+    public void testUrlChecks() {
+        assertCorrect("http://www.google.com", IntegrityCheck.URL_CHECKER);
+        assertCorrect("https://www.google.com", IntegrityCheck.URL_CHECKER);
+        assertCorrect("file://c:/asdf/asdf", IntegrityCheck.URL_CHECKER);
+        assertWrong("www.google.com", IntegrityCheck.URL_CHECKER);
+        assertWrong("google.com", IntegrityCheck.URL_CHECKER);
+        assertWrong("c:/asdf/asdf", IntegrityCheck.URL_CHECKER);
+    }
+
     @Test
     public void testYearChecks() {
         assertCorrect("2014", IntegrityCheck.YEAR_CHECKER);