Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto add "referrer header" for url link #358

Closed
g10996694 opened this issue Nov 17, 2015 · 5 comments
Closed

auto add "referrer header" for url link #358

g10996694 opened this issue Nov 17, 2015 · 5 comments
Assignees
Milestone

Comments

@g10996694
Copy link

Sometimes, the url link in the field URL has no referrer header (http://) etc.
So, when we click the link icon, JabRef showed the error that

Windows cannot find '....'. Make sure you typed the name correctly, and
then try again. To search for a file, dick the Start button, and then dick Search.

Perhaps this can be avoided by adding automatically the referrer header.
Tested on the 2.11.1
Thank you

@stefan-kolb
Copy link
Member

Personally, I'm not sure if we should add a protocol by default if it is missing. It is just a bad URL then and should be fixed by the user to get a correct field value?! Also, how can we know which protocol should be used?

@koppor
Copy link
Member

koppor commented Nov 18, 2015

This is how Chrome works. Why not just trying to add http:// if the protocol is missing?

@stefan-kolb
Copy link
Member

It's not displayed in Chrome, but prepended if you copy the URL.
Why not:

  • Do not foster unsecure http:// protocol
  • Can we be sure it is not another protocol, like a file path?

@g10996694
Copy link
Author

@stefan-kolb you are right. perhaps the right way would be check if it is a file path or url link.
thank you

@stefan-kolb stefan-kolb added this to the v3.1 milestone Dec 9, 2015
@koppor
Copy link
Member

koppor commented Jan 8, 2016

Add it to ntegrity check

Eventually, we add it to cleanup to add http before, which whould match 80% of the cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants