Fix PDF export #10361

Luggas4you · 2023-09-10T20:01:37Z

Mandatory checks

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Luggas4you · 2023-09-10T20:13:24Z

Throws Exception: Method threw 'java.lang.IllegalStateException' exception. Cannot evaluate org.apache.pdfbox.cos.COSDictionary.toString()

Siedlerchr · 2023-09-10T20:18:28Z

src/main/java/org/jabref/logic/exporter/XmpPdfExporter.java

-import java.nio.file.Path;
-import java.util.List;
-import java.util.Objects;
+        import java.io.IOException;


intendation off?

Siedlerchr · 2023-09-23T22:09:37Z

src/test/java/org/jabref/logic/exporter/XmpPdfExporterTest.java

+            }
+            exporter.exportToFileByPath(databaseContext, filePreferences, originalFilePath, abbreviationRepository);
+
+            Files.copy(Paths.get(originalFilePath.toString()), Paths.get(exportedFilePath.toString()), StandardCopyOption.REPLACE_EXISTING);


You already have two Path objects, so you don't need that wrapping here

Suggested change

Files.copy(Paths.get(originalFilePath.toString()), Paths.get(exportedFilePath.toString()), StandardCopyOption.REPLACE_EXISTING);

Files.copy(originalFilePath, exportedFilePath), StandardCopyOption.REPLACE_EXISTING);

Siedlerchr · 2023-09-23T22:12:02Z

src/test/java/org/jabref/logic/exporter/XmpPdfExporterTest.java

+            Files.copy(Paths.get(originalFilePath.toString()), Paths.get(exportedFilePath.toString()), StandardCopyOption.REPLACE_EXISTING);
+
+            try (PDDocument importedDocument = Loader.loadPDF(new File(exportedFilePath.toString()))) {
+                assertNotNull(importedDocument, "The imported document should not be null");


I would use JabRef's PDF Importer for this so you can compare the exported entries with the imported entries
PdfEmbeddedBibFileImporterTest

I added the importer and commit it

Luggas4you · 2023-09-24T19:08:11Z

I am still working on the test, these are the current results if I run the test:

Luggas4you · 2023-09-24T19:10:55Z

I am still working on the test, these are the current results if I run the test:

I don't know what the "JabRef15179252027836258260pdf" file is.

I need not to use the filePath, but I currently do not know how I can resolve it (I could use one entry but the database contain's multiple)

koppor · 2023-09-25T19:52:14Z

DevCall:

Current functionality: One can write for one PDF the XMP data (and an embedded .bib file) to the PDF:

Mass update is possible at

Currently, File -> Export also offers export to PDF (XMP or embedded .bib file). Which causes an error.

In this PR, a new PDF is created if the PDF is not found.

We looking forward to user feedback.

We should write:

nested .bib files
XMP data (maybe only generic - if more than one entry: "JabRef library")
All entries rendered using the current preview style

We could even embed the PDFs inside the PDFs.

Pro: It is super-easy now. No ZIP-file generation/export and later import.

* upstream/main: (94 commits) Bump org.openrewrite.rewrite from 6.3.11 to 6.3.16 (JabRef#10442) Update all of lucene Bump org.apache.lucene:lucene-core from 9.7.0 to 9.8.0 Bump com.dlsc.gemsfx:gemsfx from 1.77.0 to 1.82.0 Accept LaTeX errors in comment field (JabRef#10436) Fix NPEs in UrlCleanup (JabRef#10435) Fix triggering workflows (JabRef#10433) Show exception in cleanup error (JabRef#10430) Exclude check for ampersand (&) at verbatim fields (JabRef#10419) fix checkstyle fix escaping of slashes fix checkstyle and l10n Add TeXShop (macOS only) Fix casing First set fetcherWorker properties, then start the worker improve variable names checkstyle Fix fetcher worker execution on background thread Update contributing.md jakarta ...

…tworkShare * upstream/main: Infer DOI from ArXiv identifier (#10449) Add TexShop Icon (#10447) Fix PDF export (#10361) # Conflicts: # CHANGELOG.md

…in-protected-terms-files * upstream/main: Update src/main/java/org/jabref/logic/exporter/AtomicFileOutputStream.java Fix saving on network drive under macOS Infer DOI from ArXiv identifier (#10449) Add TexShop Icon (#10447) Fix PDF export (#10361) Fixed SpringerFetcherTest and ACMPortalFetcherTest (#10445) Bump org.openrewrite.rewrite from 6.3.11 to 6.3.16 (#10442) Update all of lucene Bump org.apache.lucene:lucene-core from 9.7.0 to 9.8.0 Bump com.dlsc.gemsfx:gemsfx from 1.77.0 to 1.82.0 Accept LaTeX errors in comment field (#10436) fix checkstyle fix escaping of slashes fix checkstyle and l10n Add TeXShop (macOS only)

Luggas4you added 2 commits September 9, 2023 17:10

Create PDF WIP

6f49c30

Create PDF WIP

474fb51

Siedlerchr reviewed Sep 10, 2023

View reviewed changes

Luggas4you added 2 commits September 15, 2023 16:28

Create PDF WIP

623b54b

Add @test to XmpPdfExporterTest WIP

eb3789a

Siedlerchr reviewed Sep 23, 2023

View reviewed changes

Luggas4you added 2 commits September 24, 2023 18:48

Add Importer to XmpPdfExporterTest

58dcf13

WIP

2b5838f

Luggas4you added 2 commits September 24, 2023 21:41

Fix testRoundtripExportImport

648301e

Finish testRoundtripExportImport

78fbb40

ThiloteE added the export / save label Sep 25, 2023

Luggas4you added 3 commits September 30, 2023 16:38

Add @AfterEach to XmpPdfExporterTest.java

91370ea

Change @test to @ParameterizedTest

b32f000

Delete IllegalArgumentException in XmpPdfExporter.java

1a3c47b

Siedlerchr marked this pull request as ready for review October 2, 2023 14:06

Siedlerchr added 2 commits October 3, 2023 14:18

add changelog and change message

f95373f

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 3, 2023

Siedlerchr approved these changes Oct 3, 2023

View reviewed changes

Siedlerchr added this pull request to the merge queue Oct 3, 2023

Merged via the queue into JabRef:main with commit a73bb07 Oct 3, 2023
16 checks passed

Siedlerchr mentioned this pull request Oct 11, 2023

PDF export embedded bibtex not working #10101

Closed

2 tasks

koppor mentioned this pull request Oct 12, 2023

"Embedded BibTeX pdf" export fix #10484

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix PDF export #10361

Fix PDF export #10361

Luggas4you commented Sep 10, 2023 •

edited by Siedlerchr

Loading

Luggas4you commented Sep 10, 2023

Siedlerchr Sep 10, 2023

Siedlerchr Sep 23, 2023 •

edited

Loading

Luggas4you Sep 24, 2023

Siedlerchr Sep 23, 2023

Luggas4you Sep 24, 2023

Luggas4you commented Sep 24, 2023

Luggas4you commented Sep 24, 2023

koppor commented Sep 25, 2023

	Files.copy(Paths.get(originalFilePath.toString()), Paths.get(exportedFilePath.toString()), StandardCopyOption.REPLACE_EXISTING);
	Files.copy(originalFilePath, exportedFilePath), StandardCopyOption.REPLACE_EXISTING);

Fix PDF export #10361

Fix PDF export #10361

Conversation

Luggas4you commented Sep 10, 2023 • edited by Siedlerchr Loading

Mandatory checks

Luggas4you commented Sep 10, 2023

Siedlerchr Sep 10, 2023

Choose a reason for hiding this comment

Siedlerchr Sep 23, 2023 • edited Loading

Choose a reason for hiding this comment

Luggas4you Sep 24, 2023

Choose a reason for hiding this comment

Siedlerchr Sep 23, 2023

Choose a reason for hiding this comment

Luggas4you Sep 24, 2023

Choose a reason for hiding this comment

Luggas4you commented Sep 24, 2023

Luggas4you commented Sep 24, 2023

koppor commented Sep 25, 2023

Luggas4you commented Sep 10, 2023 •

edited by Siedlerchr

Loading

Siedlerchr Sep 23, 2023 •

edited

Loading