Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PDF export #10361

Merged
merged 13 commits into from
Oct 3, 2023
Merged

Fix PDF export #10361

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6f49c30
Create PDF WIP
Luggas4you Sep 9, 2023
474fb51
Create PDF WIP
Luggas4you Sep 10, 2023
623b54b
Create PDF WIP
Luggas4you Sep 15, 2023
eb3789a
Add @Test to XmpPdfExporterTest WIP
Luggas4you Sep 23, 2023
58dcf13
Add Importer to XmpPdfExporterTest
Luggas4you Sep 24, 2023
2b5838f
WIP
Luggas4you Sep 24, 2023
648301e
Fix testRoundtripExportImport
Luggas4you Sep 24, 2023
78fbb40
Finish testRoundtripExportImport
Luggas4you Sep 24, 2023
91370ea
Add @AfterEach to XmpPdfExporterTest.java
Luggas4you Sep 30, 2023
b32f000
Change @Test to @ParameterizedTest
Luggas4you Sep 30, 2023
1a3c47b
Delete IllegalArgumentException in XmpPdfExporter.java
Luggas4you Sep 30, 2023
9c2dd3b
Merge remote-tracking branch 'upstream/main' into xmp_pdf
Siedlerchr Oct 3, 2023
f95373f
add changelog and change message
Siedlerchr Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 35 additions & 10 deletions src/main/java/org/jabref/logic/exporter/XmpPdfExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
package org.jabref.logic.exporter;

import java.nio.file.Path;
import java.util.List;
import java.util.Objects;
import java.io.IOException;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intendation off?

import java.nio.file.Path;
import java.util.List;
import java.util.Objects;

import org.jabref.logic.l10n.Localization;
import org.jabref.logic.util.StandardFileType;
import org.jabref.logic.xmp.XmpPreferences;
import org.jabref.logic.xmp.XmpUtilWriter;
import org.jabref.model.database.BibDatabaseContext;
import org.jabref.model.entry.BibEntry;
import org.jabref.logic.l10n.Localization;
import org.jabref.logic.util.StandardFileType;
import org.jabref.logic.xmp.XmpPreferences;
import org.jabref.logic.xmp.XmpUtilWriter;
import org.jabref.model.database.BibDatabaseContext;
import org.jabref.model.entry.BibEntry;

import org.apache.pdfbox.pdmodel.PDDocument;
import org.apache.pdfbox.pdmodel.PDPage;
import org.apache.pdfbox.pdmodel.PDPageContentStream;

public class XmpPdfExporter extends Exporter {

Expand All @@ -26,8 +31,28 @@ public void export(BibDatabaseContext databaseContext, Path pdfFile, List<BibEnt
Objects.requireNonNull(pdfFile);
Objects.requireNonNull(entries);

if (pdfFile.toString().endsWith(".pdf")) {
Path filePath = pdfFile.toAbsolutePath();

if (!pdfFile.toString().endsWith(".pdf")) {
throw new IllegalArgumentException("Invalid PDF file extension");
}
try (PDDocument document = new PDDocument()) {
PDPage page = new PDPage();
document.addPage(page);

PDPageContentStream contentStream = new PDPageContentStream(document, page);
contentStream.beginText();
contentStream.newLineAtOffset(25, 500);
contentStream.showText("This PDF was created by JabRef. It demonstrates the embedding of BibTeX data in PDF files. Please open the file attachments view of your PDF viewer to see the attached files. Note that the normal usage is to embed the BibTeX data in an existing PDF.");
contentStream.endText();

document.save(filePath.toString());
document.close();

new XmpUtilWriter(xmpPreferences).writeXmp(pdfFile, entries, databaseContext.getDatabase());

} catch (IOException e) {
throw new Exception("Error creating PDF", e);
}
}
}
Loading