Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JabRef icon to installer and change watermark to JabRef #4421

Merged
merged 11 commits into from
Oct 28, 2018
Merged

Add JabRef icon to installer and change watermark to JabRef #4421

merged 11 commits into from
Oct 28, 2018

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Oct 27, 2018 •
edited
Loading

Fixes #482

I also updated to the newest install4j release 4.0.8
I had to adapt Circle Ci 2.0 to create a new cache when a new version comes. So whenever the script "scripts/extract-install4j.sh" is modified, circle ci 2.0 will create a new cache.

grafik

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Siedlerchr
Add JabRef Icon to installer
0fe5486 
Change watermark from Install4j to JabRef
Update to 7.0.8
@Siedlerchr
add jabref icon as png in 64x64
3765e51
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 27, 2018
tobiasdiez
tobiasdiez approved these changes Oct 27, 2018
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the JabRef icon also shown in the left upper corner (on your screenshot it is not)?

@Siedlerchr
Copy link
Member Author

The icon in the top left corner is not changed. Have to look where to find that.

@Siedlerchr
Copy link
Member Author

Seems to be a bit more ocmplex:

Overriding standard icons
If you would like to change the standard icons in the installer, have a look at the JAR file resource/
i4jruntime.jar in the install4j installation directory. The package com.install4j.runtime.
installer.frontend.iconscontains all icons that are used by the installer. To replace some
or all of these icons with your own version, create a JAR file that contains just the new icon files
in the same directory and add it on the "Installer->Custom Code & Resources" step. The installer
will first try to load an icon from the custom code. Failing that, it will fall back to the built-in
version.

@Siedlerchr
Copy link
Member Author

Unfortunately I could not get the icon overriding working with a custom jar and I don't want to try around further. Instead I am going to merge this now.

@Siedlerchr Siedlerchr merged commit 1d8b3aa into master Oct 28, 2018
@Siedlerchr Siedlerchr deleted the iconInstaller branch October 28, 2018 11:36
Siedlerchr added a commit that referenced this pull request Nov 1, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into docbookfive
231b1eb 
* upstream/master:
  Add submodule pull to circle ci and fix theme loading css (#4443)
  fix groups drag and drop (#4439)
  Convert merge entries dialog to JavaFX (#4410)
  Fix ArrayIndexOutOfBoundsException on second pdf import (#4426)
  Fix radiobuttons in preference menu (#4409)
  Add citation styles as git submodule (#4431)
  Fix highlight color of selected text and progress bar (#4420)
  Fix two new issues
  Fix Violations of Always Use Braces (#4400)
  Delete PreferencesService.java.orig
  Add JabRef icon to installer and change watermark to JabRef (#4421)
  Checkstyle: force braces around code blocks
Siedlerchr added a commit that referenced this pull request Nov 3, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into ooPanel
f9765fc 
* upstream/master:
  New Crowdin translations (#4454)
  Fix error in l10n file: Toogle -> Toggle (#4453)
  Remove depandabot
  Bump junit-pioneer from 0.2.2 to 0.3.0 (#4451)
  Add Depandabot badge
  Emphasize that users should try out the newest version before reporting a bug
  Add a preference to add files in entry editor (#4408)
  Add submodule pull to circle ci and fix theme loading css (#4443)
  fix groups drag and drop (#4439)
  Convert merge entries dialog to JavaFX (#4410)
  Fix ArrayIndexOutOfBoundsException on second pdf import (#4426)
  Fix radiobuttons in preference menu (#4409)
  Add citation styles as git submodule (#4431)
  Fix highlight color of selected text and progress bar (#4420)
  Fix two new issues
  Fix Violations of Always Use Braces (#4400)
  Delete PreferencesService.java.orig
  Add JabRef icon to installer and change watermark to JabRef (#4421)
  Checkstyle: force braces around code blocks
Siedlerchr added a commit that referenced this pull request Dec 11, 2019
@Siedlerchr
Squashed 'src/main/resources/csl-styles/' changes from f71cd32..49a1841
96c2e99 
49a1841 Update queen-margaret-university-harvard.csl (#4443)
f841560 Create uni-bern-institut-fur-musikwissenschaft-note.csl (#4401)
6ee503c Create harvard-cite-them-right-all-authors.csl (#4416)
3eceec4 Create harvard-queen-margaret-university.csl (#4441)
3c2299d JEMS.csl (#4436)
bb2f60f Create open-window.csl (#4430)
a908ab4 Nutrition Research Reviews (#4434)
208b693 Bump nokogiri from 1.10.3 to 1.10.4 (#4439)
122a3bb Create nmfs-west-coast-region-national-environmental-policy-act.csl (#4426)
3565fc2 Update tissue-engineering.csl (#4435)
981044e Create transposition.csl (#4375)
73ef6f3 Update tissue-engineering.csl (#4431)
7c4a4cf Update r-and-d-management.csl (#4432)
8628afb Create china-national-standard-gb-t-7714-2015-numeric.csl (#4065)
6ce148c removed spaces in harvard-gesellschaft-fur-bildung-und-forschung-in-europa.csl (#4422)
2af1c6f Create japanese-journal-of-applied-physics.csl (#4425)
fc16579 Add Presses universitaires de Strasbourg style (#4411)
01e58fb Correct spacing issues and documentation link (#4423)
d97cf3f Update geistes-und-kulturwissenschaften-heilmann.csl (#4421)
017947d Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (#4413)
bffe57e Create instituto-de-pesquisas-energeticas-e-nucleares-sp.csl (#4368)
18686d1 Update and rename zeitschrift-fuer-digitale-geisteswissenschaften.csl… (#4410)
bd3a5f6 Final fix for journal article cit plus other updates - uniwersytet-im-adama-mickiewicza-w-poznaniu-wydzial-anglistyki (#4417)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 49a1841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @tobiasdiez