Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JabRef icon to installer and change watermark to JabRef #4421

Merged
merged 11 commits into from
Oct 28, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ jobs:
docker:
- image: circleci/openjdk:8-jdk
steps:
- checkout
- restore_cache:
keys:
- install4j
- checkout
- install4j-{{ checksum "scripts/extract-install4j.sh" }}
- run: scripts/download-install4j-and-jres.sh
- save_cache:
key: install4j
key: install4j-{{ checksum "scripts/extract-install4j.sh" }}
paths:
- "~/downloads"
- "~/.install4j7"
Expand All @@ -25,9 +25,9 @@ jobs:
steps:
- restore_cache:
key: dependency-cache
- restore_cache:
key: install4j
- checkout
- restore_cache:
key: install4j-{{ checksum "scripts/extract-install4j.sh" }}
- run: scripts/extract-install4j.sh
- run: install4j7/bin/install4jc --verbose --license=$INSTALL4J_KEY
- run: ./gradlew -Pdev=true -Pinstall4jDir="install4j7" release --stacktrace
Expand All @@ -46,9 +46,9 @@ jobs:
steps:
- restore_cache:
key: dependency-cache
- restore_cache:
key: install4j
- checkout
- restore_cache:
key: install4j-{{ checksum "scripts/extract-install4j.sh" }}
- run: scripts/extract-install4j.sh
- run: install4j7/bin/install4jc --verbose --license=$INSTALL4J_KEY
- run: ./gradlew -Pinstall4jDir="install4j7" release --stacktrace
Expand Down
21 changes: 15 additions & 6 deletions jabref.install4j
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<install4j version="7.0.4" transformSequenceNumber="7">
<install4j version="7.0.8" transformSequenceNumber="7">
<directoryPresets config="./buildres/jabref.json" />
<application name="JabRef" distributionSourceDir="" applicationId="0034-7691-1464-4754" mediaDir="build/install4j" mediaFilePattern="${compiler:sys.shortName}_${compiler:sys.platform}_${compiler:sys.version}" compression="6" lzmaCompression="false" pack200Compression="false" excludeSignedFromPacking="true" commonExternalFiles="false" createMd5Sums="true" shrinkRuntime="true" shortName="JabRef" publisher="JabRef Community" publisherWeb="https://www.jabref.org/" version="DEV" allPathsRelative="true" backupOnSave="false" autoSave="true" convertDotsToUnderscores="true" macSignature="????" macVolumeId="780dfea2d33a0244" javaMinVersion="1.8" javaMaxVersion="1.8" allowBetaVM="false" jdkMode="runtimeJre" jdkName="">
<languages skipLanguageSelection="true" languageSelectionInPrincipalLanguage="false">
Expand Down Expand Up @@ -42,7 +42,10 @@
<variable name="version" value="3.1dev" description="" category="" />
</variables>
<mergedProjects />
<codeSigning macEnabled="false" macPkcs12File="" windowsEnabled="false" windowsKeySource="pkcs12" windowsPvkFile="" windowsSpcFile="" windowsPkcs12File="" />
<codeSigning macEnabled="false" macPkcs12File="" windowsEnabled="false" windowsKeySource="pkcs12" windowsPvkFile="" windowsSpcFile="" windowsPkcs12File="" windowsPkcs11Library="" windowsPkcs11Slot="">
<windowsKeystoreIdentifier issuer="" serial="" subject="" />
<windowsPkcs11Identifier issuer="" serial="" subject="" />
</codeSigning>
</application>
<files keepModificationTimes="false" missingFilesStrategy="warn" globalExcludeSuffixes="" defaultOverwriteMode="4" defaultUninstallMode="0" launcherOverwriteMode="3" defaultFileMode="644" defaultDirMode="755">
<filesets />
Expand Down Expand Up @@ -105,7 +108,7 @@
<customAttributes />
</autoUpdate>
<applications>
<application name="" id="installer" customizedId="" beanClass="com.install4j.runtime.beans.applications.InstallerApplication" enabled="true" commentSet="false" comment="" actionElevationType="none" styleId="" fileset="" customIcnsFile="./src/main/resources/icons/jabref.icns" customIcoFile="./src/main/resources/icons/jabref.ico" macEntitlementsFile="" automaticLauncherIntegration="false" launchMode="startupFirstWindow" launchInNewProcess="false" launchSchedule="updateSchedule" allLaunchers="true">
<application name="" id="installer" customizedId="" beanClass="com.install4j.runtime.beans.applications.InstallerApplication" enabled="true" commentSet="false" comment="" actionElevationType="none" styleId="326" fileset="" customIcnsFile="./src/main/resources/icons/jabref.icns" customIcoFile="./src/main/resources/icons/jabref.ico" macEntitlementsFile="" automaticLauncherIntegration="false" launchMode="startupFirstWindow" launchInNewProcess="false" launchSchedule="updateSchedule" allLaunchers="true">
<serializedBean>
<java class="java.beans.XMLDecoder">
<object class="com.install4j.runtime.beans.applications.InstallerApplication">
Expand All @@ -116,6 +119,9 @@
</java>
</serializedBean>
<styleOverrides />
<customScript mode="1" file="">
<content />
</customScript>
<launcherIds />
<variables />
<startup>
Expand Down Expand Up @@ -144,7 +150,7 @@
</screen>
</startup>
<screens>
<screen name="" id="2" customizedId="" beanClass="com.install4j.runtime.beans.screens.WelcomeScreen" enabled="true" commentSet="false" comment="" actionElevationType="inherit" styleId="332" rollbackBarrier="false" rollbackBarrierExitCode="1" backButton="2" finishScreen="false" wizardIndexChangeType="unchanged" wizardIndexKey="">
<screen name="" id="2" customizedId="" beanClass="com.install4j.runtime.beans.screens.WelcomeScreen" enabled="true" commentSet="false" comment="" actionElevationType="inherit" styleId="" rollbackBarrier="false" rollbackBarrierExitCode="1" backButton="2" finishScreen="false" wizardIndexChangeType="unchanged" wizardIndexKey="">
<serializedBean>
<java class="java.beans.XMLDecoder">
<object class="com.install4j.runtime.beans.screens.WelcomeScreen" />
Expand Down Expand Up @@ -766,6 +772,9 @@ return console.askOkCancel(message, true);
</java>
</serializedBean>
<styleOverrides />
<customScript mode="1" file="">
<content />
</customScript>
<launcherIds />
<variables />
<startup>
Expand Down Expand Up @@ -1054,7 +1063,7 @@ return console.askYesNo(message, true);
<boolean>false</boolean>
</void>
<void property="labelText">
<string>install4j</string>
<string>JabRef</string>
</void>
</object>
</java>
Expand Down Expand Up @@ -1262,7 +1271,7 @@ return console.askYesNo(message, true);
</void>
<void property="imageFile">
<object class="com.install4j.api.beans.ExternalFile">
<string>icon:${installer:sys.installerApplicationMode}_header.png</string>
<string>./src/main/resources/icons/JabRef-icon-64.png</string>
</object>
</void>
<void property="imageInsets">
Expand Down
2 changes: 1 addition & 1 deletion scripts/download-install4j-and-jres.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ if [ ! -d ~/downloads ]; then
mkdir ~/downloads
fi
cd ~/downloads
wget --quiet -nc http://download-keycdn.ej-technologies.com/install4j/install4j_unix_7_0_4.tar.gz
wget --quiet -nc --show-progress http://download-keycdn.ej-technologies.com/install4j/install4j_unix_7_0_8.tar.gz

# fetch JREs
if [ ! -d ~/.install4j7/jres ]; then
Expand Down
4 changes: 2 additions & 2 deletions scripts/extract-install4j.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
tar -xf ~/downloads/install4j_unix_7_0_4.tar.gz
tar -xf ~/downloads/install4j_unix_7_0_8.tar.gz
# fix directory name (until install4j 6.1.5 it was install4j6
mv install4j7.0.4 install4j7
mv install4j7.0.8 install4j7
48 changes: 48 additions & 0 deletions src/main/java/org/jabref/preferences/PreferencesService.java.orig
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
package org.jabref.preferences;

import java.nio.file.Path;
import java.util.List;
import java.util.Map;

import org.jabref.gui.keyboard.KeyBindingRepository;
import org.jabref.logic.journals.JournalAbbreviationPreferences;
import org.jabref.logic.openoffice.OpenOfficePreferences;
import org.jabref.model.metadata.FilePreferences;

public interface PreferencesService {

JournalAbbreviationPreferences getJournalAbbreviationPreferences();

void storeKeyBindingRepository(KeyBindingRepository keyBindingRepository);

KeyBindingRepository getKeyBindingRepository();

void storeJournalAbbreviationPreferences(JournalAbbreviationPreferences abbreviationsPreferences);

FilePreferences getFilePreferences();

Path getWorkingDir();

void setWorkingDir(Path dir);

<<<<<<< HEAD
OpenOfficePreferences getOpenOfficePreferences();

void setOpenOfficePreferences(OpenOfficePreferences openOfficePreferences);

PreviewPreferences getPreviewPreferences();
=======
Map<String, List<String>> getEntryEditorTabList();

Boolean getEnforceLegalKeys();

Map<String, String> getCustomTabsNamesAndFields();

void setCustomTabsNameAndFields(String name, String fields, int defNumber);

public void purgeSeries(String prefix, int number);

public void updateEntryEditorTabList();
>>>>>>> upstream/master

}
Binary file added src/main/resources/icons/JabRef-icon-64.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.