Refactor of DOI import failure dialog, import format reader and clipboard manager #8839

zkl-ai · 2022-05-22T14:21:35Z

Fixes #8743

The modified dialog is as below.

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

ThiloteE · 2022-05-22T14:50:00Z

Will details of the "error" message show under help > event log?

src/main/java/org/jabref/gui/mergeentries/FetchAndMergeEntry.java

zkl-ai · 2022-05-22T15:10:45Z

Will details of the "error" message show under help > event log?

There are details in the help -> event log

ThiloteE · 2022-05-22T15:20:26Z

Will details of the "error" message show under help > event log?

There are details in the help -> event log

Perfect! Then I guess it is fine if the "show details" button is missing :)

@claell what do you say? :) I kinda hijacked your issue there haha :D Is this pr something you would like? :)

…o "No DOI data was found"

…g' into improve-DOI-import-failure-dialog

Localization.lang("Server Error")

Siedlerchr · 2022-05-22T20:05:39Z

src/main/java/org/jabref/gui/mergeentries/FetchAndMergeEntry.java

@@ -76,7 +76,7 @@ public void fetchAndMerge(BibEntry entry, List<Field> fields) {
                                  })
                                  .onFailure(exception -> {
                                      LOGGER.error("Error while fetching bibliographic information", exception);
-                                      String localMessage = exception.getCause().getLocalizedMessage();
+                                      String localMessage = exception.getLocalizedMessage();


Why do you use localized messge for checking here? wouldn't that faill in different languages?

I think I need to change the dialog title and content according to the localized message.

But as far as I can see, you only rely on this variable for the check logic. The value is never actually used for the dialog content.

claell · 2022-05-22T21:32:25Z

From the general approach, this looks good to me and pretty much as detailed in the original issue :) Nice that it worked out that way.

Regarding the implementation, I was wondering whether the logic of dealing with the exceptions can be improved (see comment on the code that I will post soon).

claell · 2022-05-22T21:36:56Z

src/main/java/org/jabref/gui/mergeentries/FetchAndMergeEntry.java

-                                      dialogService.showErrorDialogAndWait(exception);
+                                      String localMessage = exception.getLocalizedMessage();
+                                      // client error
+                                      if (localMessage.startsWith("Client")) {


This is the check, I am talking about. Personally, I think this should not be a string comparison, but a different, more robust check.

I assume, that @Siedlerchr had something similarly in mind with his remark.

claell · 2022-05-22T21:41:06Z

src/main/java/org/jabref/logic/importer/fetcher/DoiFetcher.java

+                        throw new FetcherException(Localization.lang("Client Error"), e);
+                    } else {
+                        throw new FetcherException(Localization.lang("Server Error"), e);


Does it make sense to give those exceptions more meaningful types? Client and Server error seem a bit too arbitrary to me. Also, are exceptions usually localized?

I would introduce new exceptions FetcherClientException extends FetcherException and FetcherServerException extends FetcherException

That would be great! If it is finished, could you inform me?

src/main/java/org/jabref/logic/importer/fetcher/DoiFetcher.java

…ption and DOIServerNotAvailableException

…g' into improve-DOI-import-failure-dialog

…ption and DOIServerNotAvailableException and improved

zkl-ai

final implementation

Fix some fetcher tests

ThiloteE · 2022-07-16T18:50:42Z

I tested again current version of this pr by entering the non-existing doi: 10.1109/REW.2016.24 into "Import by DOI"
Result:

This is unexpected, because I know the connection is good, because I can successfully import the DOI 10.1109/rew.2016.039

Worse:

copy&paste 10.1109/REW.2016.24 into the DOI field and pressing the button "Get bibliographic data from DOI" resulted in following exception:

org.jabref.logic.importer.FetcherException: Connection error
	at org.jabref@100.0.0/org.jabref.logic.importer.fetcher.DoiFetcher.performSearchById(DoiFetcher.java:106)
	at org.jabref@100.0.0/org.jabref.gui.mergeentries.FetchAndMergeEntry.lambda$fetchAndMerge$0(FetchAndMergeEntry.java:68)
	at org.jabref@100.0.0/org.jabref.gui.util.BackgroundTask$1.call(BackgroundTask.java:60)
	at org.jabref@100.0.0/org.jabref.gui.util.DefaultTaskExecutor$1.call(DefaultTaskExecutor.java:161)
	at javafx.graphics@18.0.1/javafx.concurrent.Task$TaskCallable.call(Task.java:1426)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.io.FileNotFoundException: https://doi.org/10.1109/REW.2016.24
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:67)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:483)
	at java.base/sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:2048)
	at java.base/sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:2043)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:569)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:2042)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1609)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1589)
	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:224)
	at org.jabref@100.0.0/org.jabref.logic.net.URLDownload.asString(URLDownload.java:241)
	at org.jabref@100.0.0/org.jabref.logic.net.URLDownload.asString(URLDownload.java:254)
	at org.jabref@100.0.0/org.jabref.logic.importer.fetcher.DoiFetcher.performSearchById(DoiFetcher.java:80)
	... 10 more
Caused by: java.io.FileNotFoundException: https://doi.org/10.1109/REW.2016.24
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1993)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1589)
	at java.base/java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:529)
	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:308)
	at org.jabref@100.0.0/org.jabref.logic.net.URLDownload.openConnection(URLDownload.java:354)
	... 13 more

Again: I know connection to the DOI server is not the problem. The problem is that this DOI cannot be found (probably because it does not exist, but there also could be a typo by the user or it simply is not in the system serverside)

Siedlerchr · 2022-07-16T19:06:29Z

Yeah, this comes from my latest changes. The problem is that the fetcher tests expect empty entries on 404. I will come up with a better solution.

throw exception on 404 todo fix tests

…failure-dialog * upstream/main: Update Gradle Wrapper from 7.4.2 to 7.5. (JabRef#8986) New translations JabRef_en.properties (Russian) (JabRef#8985)

ThiloteE · 2022-07-18T20:15:56Z

Optional notification messages:

Bibliographic data not found. Cause is likely the client side. Please check connection and identifier for correctness
Bibliographic data not found. Cause is likely the client side. Please check connection and input.
Bibliographic data not found. Cause is likely the client side: Http error code XXX.
Bibliographic data not found. Please check the connection and if the identifier is correct.
Bibliographic data not found. Please check user input and connection.
Bibliographic data not found. Please check correctness of identifier and connection. The server responded with HTTP status code XXX, which means, the error is likely caused at the client side.

Siedlerchr · 2022-07-19T17:55:32Z

same also now for the new entry types dialog

…failure-dialog * upstream/main: Reworded t in pr (JabRef#8989) Fixed checkstyle (JabRef#8990) Fix RfcFetcherTest (JabRef#8988) Fixes koppor#521 - Allow to drag&drop selected bib entries to other library tabs (JabRef#8982) # Conflicts: # src/main/java/org/jabref/gui/maintable/MainTable.java # src/test/java/org/jabref/logic/importer/fetcher/JstorFetcherTest.java

ThiloteE · 2022-07-21T10:57:24Z

Meh. Found another ugly error message with current build:

How to reproduce:

Turn off your internet connection
Go to General Tab of entry editor. Enter blabla into the DOI field.
Press Search DOI button at the right side.

Result:

Following error message:

org.jabref.logic.importer.FetcherException: An I/O exception occurred
	at org.jabref@100.0.0/org.jabref.logic.importer.IdParserFetcher.findIdentifier(IdParserFetcher.java:95)
	at org.jabref@100.0.0/org.jabref.gui.fieldeditors.IdentifierEditorViewModel.lambda$lookupIdentifier$5(IdentifierEditorViewModel.java:119)
	at org.jabref@100.0.0/org.jabref.gui.util.BackgroundTask$1.call(BackgroundTask.java:60)
	at org.jabref@100.0.0/org.jabref.gui.util.DefaultTaskExecutor$1.call(DefaultTaskExecutor.java:161)
	at javafx.graphics@18.0.1/javafx.concurrent.Task$TaskCallable.call(Task.java:1426)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.net.SocketException: Das Netzwerk ist nicht erreichbar
	at java.base/sun.nio.ch.Net.connect0(Native Method)
	at java.base/sun.nio.ch.Net.connect(Net.java:579)
	at java.base/sun.nio.ch.Net.connect(Net.java:568)
	at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:585)
	at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:327)
	at java.base/java.net.Socket.connect(Socket.java:633)
	at java.base/sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:299)
	at java.base/sun.security.ssl.BaseSSLSocketImpl.connect(BaseSSLSocketImpl.java:174)
	at java.base/sun.net.NetworkClient.doConnect(NetworkClient.java:183)
	at java.base/sun.net.www.http.HttpClient.openServer(HttpClient.java:498)
	at java.base/sun.net.www.http.HttpClient.openServer(HttpClient.java:603)
	at java.base/sun.net.www.protocol.https.HttpsClient.<init>(HttpsClient.java:264)
	at java.base/sun.net.www.protocol.https.HttpsClient.New(HttpsClient.java:378)
	at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.getNewHttpClient(AbstractDelegateHttpsURLConnection.java:189)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1242)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1128)
	at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:175)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1665)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1589)
	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:224)
	at java.base/java.net.URL.openStream(URL.java:1161)
	at org.jabref@100.0.0/org.jabref.logic.importer.IdParserFetcher.findIdentifier(IdParserFetcher.java:74)
	... 10 more

Expected result:

Nice looking notification. E.g Something like this:

Network not available. (i think this one should already suffice 👍 )

Alternatives:
Network not available. Please check your connection
Network not available. Please check your (internet-) connection
DOI not found, because the network is not available. Please check your connection

ThiloteE · 2022-07-21T11:20:05Z

Similarly:

How to reproduce:

Turn off your internet connection
Go to General Tab of entry editor. Enter blabla into the DOI field.
Press Get bibliographic data from DOI button at the right side.

Result:

Following error message:

org.jabref.logic.importer.FetcherException: Connection error
	at org.jabref@100.0.0/org.jabref.logic.importer.fetcher.DoiFetcher.performSearchById(DoiFetcher.java:106)
	at org.jabref@100.0.0/org.jabref.gui.mergeentries.FetchAndMergeEntry.lambda$fetchAndMerge$0(FetchAndMergeEntry.java:68)
	at org.jabref@100.0.0/org.jabref.gui.util.BackgroundTask$1.call(BackgroundTask.java:60)
	at org.jabref@100.0.0/org.jabref.gui.util.DefaultTaskExecutor$1.call(DefaultTaskExecutor.java:161)
	at javafx.graphics@18.0.1/javafx.concurrent.Task$TaskCallable.call(Task.java:1426)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.net.UnknownHostException: doi.org
	at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:564)
	at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:327)
	at java.base/java.net.Socket.connect(Socket.java:633)
	at java.base/sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:299)
	at java.base/sun.net.NetworkClient.doConnect(NetworkClient.java:178)
	at java.base/sun.net.www.http.HttpClient.openServer(HttpClient.java:498)
	at java.base/sun.net.www.http.HttpClient.openServer(HttpClient.java:603)
	at java.base/sun.net.www.protocol.https.HttpsClient.<init>(HttpsClient.java:264)
	at java.base/sun.net.www.protocol.https.HttpsClient.New(HttpsClient.java:378)
	at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.getNewHttpClient(AbstractDelegateHttpsURLConnection.java:189)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1242)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1128)
	at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:175)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1665)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1589)
	at java.base/java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:529)
	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:308)
	at org.jabref@100.0.0/org.jabref.logic.net.URLDownload.openConnection(URLDownload.java:354)
	at org.jabref@100.0.0/org.jabref.logic.net.URLDownload.asString(URLDownload.java:241)
	at org.jabref@100.0.0/org.jabref.logic.net.URLDownload.asString(URLDownload.java:254)
	at org.jabref@100.0.0/org.jabref.logic.importer.fetcher.DoiFetcher.getAgency(DoiFetcher.java:138)
	at org.jabref@100.0.0/org.jabref.logic.importer.fetcher.DoiFetcher.performSearchById(DoiFetcher.java:71)

Expectations are roughly similar as described in last comment above, but of course adapted to include "Bibliographic data not found".

Siedlerchr · 2022-07-29T21:20:42Z

TODO: Check exception handling in Composite fetchers

…failure-dialog * upstream/main: (31 commits) Snapcraft and issue template Show development information\n\n+semver: minor Release v5.7 New Crowdin updates (JabRef#9030) New Crowdin updates (JabRef#9029) [Bot] Update CSL styles (JabRef#9027) Add missing translations for AutomaticFieldEditor (JabRef#9028) [Bot] Update Journal abbrev list (JabRef#9026) Rating in main table (JabRef#9023) New Crowdin updates (JabRef#9024) New Crowdin updates (JabRef#9016) New Crowdin updates (JabRef#9013) try to gather more output from LO exception (JabRef#9002) Improve Automatic Field Editor Dialog (JabRef#8973) Update BST VM to Antlr4 (JabRef#8934) Support biblatex apa citation for legal entry types (JabRef#8966) Bump junit-jupiter from 5.8.2 to 5.9.0 (JabRef#9012) Bump lucene-core from 9.2.0 to 9.3.0 (JabRef#9009) Bump checkstyle from 10.3.1 to 10.3.2 (JabRef#9006) Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (JabRef#9005) ...

…rg.jsoup-jsoup-1.15.2 * upstream/main: (34 commits) Refactor of DOI import failure dialog, import format reader and clipboard manager (#8839) Snapcraft and issue template Show development information\n\n+semver: minor Release v5.7 New Crowdin updates (#9030) New Crowdin updates (#9029) [Bot] Update CSL styles (#9027) Add missing translations for AutomaticFieldEditor (#9028) [Bot] Update Journal abbrev list (#9026) Rating in main table (#9023) New Crowdin updates (#9024) New Crowdin updates (#9016) New Crowdin updates (#9013) try to gather more output from LO exception (#9002) Improve Automatic Field Editor Dialog (#8973) Update BST VM to Antlr4 (#8934) Support biblatex apa citation for legal entry types (#8966) Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012) Bump lucene-core from 9.2.0 to 9.3.0 (#9009) Bump checkstyle from 10.3.1 to 10.3.2 (#9006) ...

* upstream/main: (31 commits) Citavi Importer - Import all knowledge items (JabRef#9043) Fixed table update in eft preferences (JabRef#9051) Keep EOL setting at backups (JabRef#9048) ExternalFileTypes singleton refactor (JabRef#9044) Fix dead link (JabRef#9047) Fix performance regresssion (JabRef#9045) Update javafx to 18.02 import citavi knowledge items (JabRef#9033) Fix .gitattributes for CHANGELOG.md [GSOC22] - B - Implement merging fields in the three way merge UI (JabRef#9022) [GSOC22] - A - Implement a fully functional three way merge UI (JabRef#8945) Change button label from "Return to JabRef" to "Return to library" (JabRef#9039) Bump postgresql from 42.4.0 to 42.4.1 (JabRef#9036) Bump org.javamodularity.moduleplugin from 1.8.11 to 1.8.12 (JabRef#9037) Bump slf4j-api from 2.0.0-alpha7 to 2.0.0-beta1 (JabRef#9035) Bump slf4j-api from 2.0.0-alpha7 to 2.0.0-beta1 in /buildSrc (JabRef#9038) Update Gradle Wrapper from 7.5 to 7.5.1. (JabRef#9034) Refactor of DOI import failure dialog, import format reader and clipboard manager (JabRef#8839) Snapcraft and issue template Show development information\n\n+semver: minor ...

zkl-ai and others added 3 commits April 30, 2022 12:13

Rename cleanup actions: "Make LaTeX ready" and "Make BibTeX ready"

02481fa

modify dio exception handler

07345ea

Merge branch 'JabRef:main' into improve-DOI-import-failure-dialog

f786412

ThiloteE reviewed May 22, 2022

View reviewed changes

src/main/java/org/jabref/gui/mergeentries/FetchAndMergeEntry.java Outdated Show resolved Hide resolved

zkl-ai added 2 commits May 22, 2022 23:28

modify dio exception handler change dialog from "No DOI data exits" t…

f06021a

…o "No DOI data was found"

Merge remote-tracking branch 'origin/improve-DOI-import-failure-dialo…

2348a34

…g' into improve-DOI-import-failure-dialog

zkl-ai marked this pull request as draft May 22, 2022 16:13

modify Localization.lang(message)

d32eae2

ThiloteE added ui fetcher Logging labels May 22, 2022

zkl-ai and others added 4 commits May 22, 2022 09:35

Merge branch 'JabRef:main' into improve-DOI-import-failure-dialog

987d5df

modify Localization.lang("Client Error") and

a6ec469

Localization.lang("Server Error")

pass LocalizationConsistencyTest

b3ac167

pass fetcher test

6bf38c4

Siedlerchr reviewed May 22, 2022

View reviewed changes

claell reviewed May 22, 2022

View reviewed changes

src/main/java/org/jabref/logic/importer/fetcher/DoiFetcher.java Outdated Show resolved Hide resolved

zkl-ai and others added 4 commits May 23, 2022 19:55

Merge branch 'JabRef:main' into improve-DOI-import-failure-dialog

58361cb

improve the implementation with two add Exception DOIDataNotFoundExce…

8e5b82a

…ption and DOIServerNotAvailableException

Merge remote-tracking branch 'origin/improve-DOI-import-failure-dialo…

d406d5a

…g' into improve-DOI-import-failure-dialog

improve the implementation with two add Exception DOIDataNotFoundExce…

38f3e52

…ption and DOIServerNotAvailableException and improved

zkl-ai commented May 24, 2022

View reviewed changes

zkl-ai requested a review from ThiloteE May 24, 2022 04:33

zkl-ai marked this pull request as ready for review May 25, 2022 01:53

ThiloteE changed the title ~~Improve DOI import failure dialog. Do not show exception in the gui~~ Refactor DOI import failure dialog and clipboard manager Jul 16, 2022

ThiloteE changed the title ~~Refactor DOI import failure dialog and clipboard manager~~ Refactors DOI import failure dialog, import format reader and clipboard manager Jul 16, 2022

ThiloteE added import type: performance labels Jul 16, 2022

ThiloteE changed the title ~~Refactors DOI import failure dialog, import format reader and clipboard manager~~ Refactor of DOI import failure dialog, import format reader and clipboard manager Jul 16, 2022

do not throw 404 errors from UrlDownload

a03e25f

Fix some fetcher tests

Siedlerchr added 4 commits July 16, 2022 21:16

better error messages

32fd370

throw exception on 404 todo fix tests

checkstyle

a9c4589

Merge remote-tracking branch 'upstream/main' into improve-DOI-import-…

0165d14

…failure-dialog * upstream/main: Update Gradle Wrapper from 7.4.2 to 7.5. (JabRef#8986) New translations JabRef_en.properties (Russian) (JabRef#8985)

improve dialog messages

73a88b7

This comment was marked as outdated.

Sign in to view

change l10n

5060e34

Siedlerchr added 4 commits July 19, 2022 19:56

fix merge conflicts

4c0ebd1

fix l10n messages

0cc4826

fix checkstyle and fetcher

369310e

Siedlerchr added 4 commits August 5, 2022 18:44

improve error messages

c47ea2d

further fixes

be99801

fix l10n

7c609f3

calixtus merged commit 16de272 into JabRef:main Aug 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor of DOI import failure dialog, import format reader and clipboard manager #8839

Refactor of DOI import failure dialog, import format reader and clipboard manager #8839

zkl-ai commented May 22, 2022 •

edited

Loading

ThiloteE commented May 22, 2022

zkl-ai commented May 22, 2022 •

edited

Loading

ThiloteE commented May 22, 2022

Siedlerchr May 22, 2022 •

edited

Loading

zkl-ai May 22, 2022

claell May 22, 2022

claell commented May 22, 2022

claell May 22, 2022

claell May 22, 2022

koppor May 23, 2022

zkl-ai May 24, 2022

zkl-ai left a comment

ThiloteE commented Jul 16, 2022

Siedlerchr commented Jul 16, 2022

This comment was marked as outdated.

ThiloteE commented Jul 18, 2022 •

edited

Loading

Siedlerchr commented Jul 19, 2022

ThiloteE commented Jul 21, 2022 •

edited

Loading

ThiloteE commented Jul 21, 2022 •

edited

Loading

Siedlerchr commented Jul 29, 2022

Refactor of DOI import failure dialog, import format reader and clipboard manager #8839

Refactor of DOI import failure dialog, import format reader and clipboard manager #8839

Conversation

zkl-ai commented May 22, 2022 • edited Loading

ThiloteE commented May 22, 2022

zkl-ai commented May 22, 2022 • edited Loading

ThiloteE commented May 22, 2022

Siedlerchr May 22, 2022 • edited Loading

Choose a reason for hiding this comment

zkl-ai May 22, 2022

Choose a reason for hiding this comment

claell May 22, 2022

Choose a reason for hiding this comment

claell commented May 22, 2022

claell May 22, 2022

Choose a reason for hiding this comment

claell May 22, 2022

Choose a reason for hiding this comment

koppor May 23, 2022

Choose a reason for hiding this comment

zkl-ai May 24, 2022

Choose a reason for hiding this comment

zkl-ai left a comment

Choose a reason for hiding this comment

ThiloteE commented Jul 16, 2022

Siedlerchr commented Jul 16, 2022

This comment was marked as outdated.

ThiloteE commented Jul 18, 2022 • edited Loading

Siedlerchr commented Jul 19, 2022

ThiloteE commented Jul 21, 2022 • edited Loading

ThiloteE commented Jul 21, 2022 • edited Loading

Siedlerchr commented Jul 29, 2022

zkl-ai commented May 22, 2022 •

edited

Loading

zkl-ai commented May 22, 2022 •

edited

Loading

Siedlerchr May 22, 2022 •

edited

Loading

ThiloteE commented Jul 18, 2022 •

edited

Loading

ThiloteE commented Jul 21, 2022 •

edited

Loading

ThiloteE commented Jul 21, 2022 •

edited

Loading