Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep EOL setting at backups #9048

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Keep EOL setting at backups #9048

merged 3 commits into from
Aug 12, 2022

Conversation

koppor
Copy link
Member

@koppor koppor commented Aug 11, 2022

The BackupManager did not honor the EOL setting of the library. It could be that users hit strange messages when starting JabRef. This PR fixes that.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr merged commit c82fc17 into main Aug 12, 2022
@Siedlerchr Siedlerchr deleted the fix-line-ending-backup-manager branch August 12, 2022 15:01
Siedlerchr added a commit that referenced this pull request Aug 12, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into followUpCitativKnow…
86d70b5 
…ledgeItems

* upstream/main:
  Fixed table update in eft preferences (#9051)
  Keep EOL setting at backups (#9048)
  ExternalFileTypes singleton refactor (#9044)
  Fix dead link (#9047)
  Fix performance regresssion (#9045)

# Conflicts:
#	CHANGELOG.md
Siedlerchr added a commit to koppor/jabref that referenced this pull request Aug 14, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into controlsfx-tags
e95ef25 
* upstream/main: (31 commits)
  Citavi Importer - Import all knowledge items (JabRef#9043)
  Fixed table update in eft preferences (JabRef#9051)
  Keep EOL setting at backups (JabRef#9048)
  ExternalFileTypes singleton refactor (JabRef#9044)
  Fix dead link (JabRef#9047)
  Fix performance regresssion (JabRef#9045)
  Update javafx to 18.02
  import citavi knowledge items (JabRef#9033)
  Fix .gitattributes for CHANGELOG.md
  [GSOC22] - B - Implement merging fields in the three way merge UI (JabRef#9022)
  [GSOC22] - A - Implement a fully functional three way merge UI (JabRef#8945)
  Change button label from "Return to JabRef" to "Return to library" (JabRef#9039)
  Bump postgresql from 42.4.0 to 42.4.1 (JabRef#9036)
  Bump org.javamodularity.moduleplugin from 1.8.11 to 1.8.12 (JabRef#9037)
  Bump slf4j-api from 2.0.0-alpha7 to 2.0.0-beta1 (JabRef#9035)
  Bump slf4j-api from 2.0.0-alpha7 to 2.0.0-beta1 in /buildSrc (JabRef#9038)
  Update Gradle Wrapper from 7.5 to 7.5.1. (JabRef#9034)
  Refactor of DOI import failure dialog, import format reader and clipboard manager (JabRef#8839)
  Snapcraft and issue template
  Show development information\n\n+semver: minor
  ...
Siedlerchr added a commit that referenced this pull request Aug 21, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
92a8b02 
* upstream/main:
  Citavi Importer - Import all knowledge items (#9043)
  Fixed table update in eft preferences (#9051)
  Keep EOL setting at backups (#9048)
  ExternalFileTypes singleton refactor (#9044)
  Fix dead link (#9047)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @Siedlerchr