Fix empty fields being added to the entry table preferences #9916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
previously approved these changes
May 18, 2023
Siedlerchr
added
the
status: ready-for-review
calixtus
approved these changes
May 18, 2023
|
Thanks for the fix. Looking forward for more. 😍 |
Siedlerchr
added a commit
that referenced
this pull request
May 18, 2023
* upstream/main: (302 commits) Fix empty fields being added to the entry table preferences (#9916) checkstyle Fixed tests by reverting development artifact Fixed checkstyle Fixed test remove empty lines move to entry editor prefs Reduced use of Globals for fileUpdateMonitor, removed unused themeManager vars reformulate Update src/main/java/org/jabref/logic/importer/fileformat/BibtexParser.java fix checkstyle Modernize tests at BibtexParserTest Removed ImportFormatReader from Globals at all Fixes some JavaDoc errors Add newline Really fix order Fix CHANGELOG.md order Fix checkstyle Update CHANGELOG.md move to entry editor editor tab ... # Conflicts: # docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md
Siedlerchr
added a commit
that referenced
this pull request
May 20, 2023
…hEncoding * upstream/main: Add fill in of selectedApplicationProperty when opening the editDialog of external application preference (#9921) Fix empty fields being added to the entry table preferences (#9916) checkstyle Update tinylog.properties Fixed command name More error handling Fix IOUtils usage Add xdg-user-dirs call to Linux.java Fix formatting Check for existance Incorporate user feedback Fix tests Respect OS language at NativeDesktop#getDefaultFileChooserDirectory # Conflicts: # CHANGELOG.md
Siedlerchr
added a commit
that referenced
this pull request
May 20, 2023
…ment * upstream/main: Add fill in of selectedApplicationProperty when opening the editDialog of external application preference (#9921) Fix empty fields being added to the entry table preferences (#9916) checkstyle Update tinylog.properties Fixed command name More error handling Fix IOUtils usage Add xdg-user-dirs call to Linux.java Fix formatting Check for existance Incorporate user feedback Fix tests Respect OS language at NativeDesktop#getDefaultFileChooserDirectory
Siedlerchr
added a commit
that referenced
this pull request
May 21, 2023
…ment * upstream/main: Add fill in of selectedApplicationProperty when opening the editDialog of external application preference (#9921) Fix empty fields being added to the entry table preferences (#9916) checkstyle Update tinylog.properties Fixed command name More error handling Fix IOUtils usage Add xdg-user-dirs call to Linux.java Fix formatting Check for existance Incorporate user feedback Fix tests Respect OS language at NativeDesktop#getDefaultFileChooserDirectory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9913
In the
Entry Table- tab in Preferences, you can add custom columns by specifying a name in the combobox below the grid. If you type in something into the textfield and delete it, you can still add a custom column entry into the list, despite the textfield being empty.We add one more check for the actual textual content to avoid this bug.
Compulsory checks