Add fill in of selectedApplicationProperty when opening the editDialog of external application preference #9921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g of external application preference
…hould-offer-existing-value-for-editing-issue-9895
calixtus
approved these changes
May 18, 2023
Siedlerchr
approved these changes
May 18, 2023
|
Thank you for your contribution. We would be happy to see more contributions from your side. We use the label good-first-issue, where more issues will be tagged. You can also have a look at https://github.com/koppor/jabref/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22. |
Siedlerchr
added a commit
that referenced
this pull request
May 20, 2023
…hEncoding * upstream/main: Add fill in of selectedApplicationProperty when opening the editDialog of external application preference (#9921) Fix empty fields being added to the entry table preferences (#9916) checkstyle Update tinylog.properties Fixed command name More error handling Fix IOUtils usage Add xdg-user-dirs call to Linux.java Fix formatting Check for existance Incorporate user feedback Fix tests Respect OS language at NativeDesktop#getDefaultFileChooserDirectory # Conflicts: # CHANGELOG.md
Siedlerchr
added a commit
that referenced
this pull request
May 20, 2023
…ment * upstream/main: Add fill in of selectedApplicationProperty when opening the editDialog of external application preference (#9921) Fix empty fields being added to the entry table preferences (#9916) checkstyle Update tinylog.properties Fixed command name More error handling Fix IOUtils usage Add xdg-user-dirs call to Linux.java Fix formatting Check for existance Incorporate user feedback Fix tests Respect OS language at NativeDesktop#getDefaultFileChooserDirectory
Siedlerchr
added a commit
that referenced
this pull request
May 21, 2023
…ment * upstream/main: Add fill in of selectedApplicationProperty when opening the editDialog of external application preference (#9921) Fix empty fields being added to the entry table preferences (#9916) checkstyle Update tinylog.properties Fixed command name More error handling Fix IOUtils usage Add xdg-user-dirs call to Linux.java Fix formatting Check for existance Incorporate user feedback Fix tests Respect OS language at NativeDesktop#getDefaultFileChooserDirectory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9895
In Preferences, in the External file types tab, if an application is set for an entry and you try to edit said entry, the application path doesn't fill in into the selected-application field of the dialog window. This change fixes that by setting that value from the 'external file types' viewmodel.
Compulsory checks