Add compile-time support for allowSystemProxy client config setting
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, it's not possible to use aws-kms-pkcs11 with a proxy other than by manually editing source code and recompiling. This is obviously less-than-ideal. The AWS C++ SDK recently added support for honoring traditional system proxy environment variables [1]. This commit starts using this new option in aws-kms-pkcs11. The setting defaults to off, because the PR was only merged relatively recently (Sept 2023) and is not likely to have made it into distribution repositories yet. The setting can be toggled at compile time by setting `AWS_SDK_USE_SYSTEM_PROXY=y`, following the existing y/n conventions. Documentation is updated accordingly. [1] aws/aws-sdk-cpp#2679
|
Cool, this works for me. Since the library is statically linked in the CI build, I'd also be ok not hiding this behind a flag and bumping that, making it the minimum version to compile. Though as I recall updating the SDK version in the CI build was kind of painful last time I tried. 😅 |
JackOfMostTrades
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, it's not possible to use aws-kms-pkcs11 with a proxy other than by manually editing source code and recompiling. This is obviously less-than-ideal.
The AWS C++ SDK recently added support for honoring traditional system proxy environment variables [1]. This commit starts using this new option in aws-kms-pkcs11.
The setting defaults to off, because the PR was only merged relatively recently (Sept 2023) and is not likely to have made it into distribution repositories yet. The setting can be toggled at compile time by setting
AWS_SDK_USE_SYSTEM_PROXY=y, following the existing y/n conventions.Documentation is updated accordingly.
[1] aws/aws-sdk-cpp#2679