Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile-time support for allowSystemProxy client config setting #30

Merged
merged 1 commit into from
Jan 23, 2024

Commits on Jan 19, 2024

  1. Add compile-time support for allowSystemProxy client config setting

    At present, it's not possible to use aws-kms-pkcs11 with a proxy other
    than by manually editing source code and recompiling. This is obviously
    less-than-ideal.
    
    The AWS C++ SDK recently added support for honoring traditional system
    proxy environment variables [1]. This commit starts using this new
    option in aws-kms-pkcs11.
    
    The setting defaults to off, because the PR was only merged relatively
    recently (Sept 2023) and is not likely to have made it into distribution
    repositories yet. The setting can be toggled at compile time by setting
    `AWS_SDK_USE_SYSTEM_PROXY=y`, following the existing y/n conventions.
    
    Documentation is updated accordingly.
    
    [1] aws/aws-sdk-cpp#2679
    fuhry committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    458addb View commit details
    Browse the repository at this point in the history