Get rid of the applicable call in rand(Range1) #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, that seems much more reasonable. cc: @JeffBezanson, @ViralBShah |
JeffBezanson
added a commit
that referenced
this pull request
Jul 18, 2013
Get rid of the applicable call in rand(Range1)
ViralBShah
added
the
domain:randomness
KristofferC
pushed a commit
that referenced
this pull request
Feb 1, 2024
Stdlib: Pkg URL: https://github.com/JuliaLang/Pkg.jl.git Stdlib branch: master Julia branch: master Old commit: ba4955e2e New commit: f3b81f1aa Julia version: 1.11.0-DEV Pkg version: 1.11.0 Bump invoked by: @KristofferC Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaLang/Pkg.jl@ba4955e...f3b81f1 ``` $ git log --oneline ba4955e2e..f3b81f1aa f3b81f1aa disable `julia_version` tests (#3773) b13bd2ddf support the "path" key in Project.toml, (#3756) 731105126 why: show more when package is both a direct and indirect dep (#3771) a83783ecb Avoid deleting existing artifacts when ignoring hashes. (#3768) b43187590 ignore tree hashes on Windows w/o symlink capability (#3764) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on multiple dispatch mechanism, we can get rid of the applicable call which is a performance killer for the function
rand.This version is about 16x - 20x faster than the original one.
This is the first step to address #3751.