Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added @timedwait #3764

Merged
merged 1 commit into from
Jul 19, 2013
Merged

Added @timedwait #3764

merged 1 commit into from
Jul 19, 2013

Conversation

amitmurthy
Copy link
Contributor

Closes #3753

amitmurthy added a commit that referenced this pull request Jul 19, 2013
@amitmurthy
Merge pull request #3764 from amitmurthy/amitm/timedwait
0804aca 
Added @timedwait
@amitmurthy amitmurthy merged commit 0804aca into JuliaLang:master Jul 19, 2013
@StefanKarpinski
Copy link
Sponsor Member

I'm not thrilled with this interface. In general using symbols to indicate status codes seems like a pretty awkward way to go.

@StefanKarpinski
Copy link
Sponsor Member

I'm also unclear on why this has to be a macro and not a higher order function. I know it's a bit annoying, but I'd really prefer to have a bit more discussion before adding exported names that we have to support indefinitely.

@amitmurthy
Copy link
Contributor Author

My apologies - I thought I had a signoff based on the discussion in #3753 and since no other code depends on this right now, I went ahead and merged.

Using symbols is a standard practice in some other languages like Erlang.
What would be the Julian way? Should I just return an integer, -1 for error, 0 for OK, 1 for timeout?

A higher order function can do as well... timedwait(ex::Expr, secs::Float; pollint::Float=0.1) where secs is the timeout in seconds and pollint is the polling interval?

@StefanKarpinski
Copy link
Sponsor Member

No worries, I just didn't feel like that conversation had quite reached a consensus.

@amitmurthy amitmurthy mentioned this pull request Jul 22, 2013
Merged
KristofferC pushed a commit that referenced this pull request Feb 1, 2024
@DilumAluthgeBot @DilumAluthge
🤖 [master] Bump the Pkg stdlib from ba4955e2e to f3b81f1aa (#53138)
e7a1c7f 
Stdlib: Pkg
URL: https://github.com/JuliaLang/Pkg.jl.git
Stdlib branch: master
Julia branch: master
Old commit: ba4955e2e
New commit: f3b81f1aa
Julia version: 1.11.0-DEV
Pkg version: 1.11.0
Bump invoked by: @KristofferC
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaLang/Pkg.jl@ba4955e...f3b81f1

```
$ git log --oneline ba4955e2e..f3b81f1aa
f3b81f1aa disable `julia_version` tests (#3773)
b13bd2ddf support the "path" key in Project.toml, (#3756)
731105126 why: show more when package is both a direct and indirect dep (#3771)
a83783ecb Avoid deleting existing artifacts when ignoring hashes. (#3768)
b43187590 ignore tree hashes on Windows w/o symlink capability (#3764)
```

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC @waitfor
2 participants
@amitmurthy @StefanKarpinski