-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shell check warnings #242
Merged
ReFil
merged 2 commits into
KinesisCorporation:V3.0
from
S0AndS0:fix-shell-check-warnings
Oct 9, 2023
Merged
Fix shell check warnings #242
ReFil
merged 2 commits into
KinesisCorporation:V3.0
from
S0AndS0:fix-shell-check-warnings
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM, Thanks for this! |
sanderdrummer
added a commit
to sanderdrummer/Adv360-Pro-ZMK
that referenced
this pull request
Oct 19, 2023
* Add instructions for upgrading from V2 to V3 in README (KinesisCorporation#197) This commit adds a new section in the README.md file detailing instructions for users upgrading from V2 to V3. * Add CHANGELOG (KinesisCorporation#221) * Readme rewrite (KinesisCorporation#222) * Fix shell check warnings (KinesisCorporation#242) * Fix SC2002 Shell Check warning * Fix SC2086 Shell Check warnings * Further documentation work (KinesisCorporation#241) * Minor cleanup, change date format, add beta testing * Update CHANGELOG.md * feat: update keymap --------- Co-authored-by: Santhosh Kannan <santhoshknn@gmail.com> Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com> Co-authored-by: S0AndS0 <strangerthanbland@gmail.com>
clayne11
pushed a commit
to clayne11/Adv360-Pro-ZMK
that referenced
this pull request
Nov 18, 2023
* Fix SC2002 Shell Check warning * Fix SC2086 Shell Check warnings
Shamasher
pushed a commit
to Shamasher/Adv360-Pro-ZMK-fork
that referenced
this pull request
Nov 22, 2023
* Fix SC2002 Shell Check warning * Fix SC2086 Shell Check warnings
Coobaha
added a commit
to Coobaha/Adv360-Pro-ZMK
that referenced
this pull request
Nov 26, 2023
* upstream/V3.0: Revert "Add version macro to keymap.json (KinesisCorporation#269)" Add version macro to keymap.json (KinesisCorporation#269) Changelog new base ZMK update (KinesisCorporation#268) Version compiled FW with automatic macro (KinesisCorporation#267) Document new NKRO settings (KinesisCorporation#264) Improve documentation based on feedback (KinesisCorporation#260) Update reset file Update ZMK (KinesisCorporation#248) Further documentation work (KinesisCorporation#241) Fix shell check warnings (KinesisCorporation#242) Readme rewrite (KinesisCorporation#222) Add CHANGELOG (KinesisCorporation#221) # Conflicts: # Makefile # config/adv360.keymap
asmodeus812
pushed a commit
to asmodeus812/Adv360-Pro
that referenced
this pull request
Dec 6, 2023
* Fix SC2002 Shell Check warning * Fix SC2086 Shell Check warnings
alok
added a commit
to alok/Adv360-Pro-ZMK
that referenced
this pull request
Dec 6, 2023
* upstream/V3.0: Update bluetooth settings in light of user feedback (KinesisCorporation#289) Revert "Add version macro to keymap.json (KinesisCorporation#269)" Add version macro to keymap.json (KinesisCorporation#269) Changelog new base ZMK update (KinesisCorporation#268) Version compiled FW with automatic macro (KinesisCorporation#267) Document new NKRO settings (KinesisCorporation#264) Improve documentation based on feedback (KinesisCorporation#260) Update reset file Update ZMK (KinesisCorporation#248) Further documentation work (KinesisCorporation#241) Fix shell check warnings (KinesisCorporation#242) Readme rewrite (KinesisCorporation#222) Add CHANGELOG (KinesisCorporation#221)
noseworthy
pushed a commit
to noseworthy/Adv360-Pro-ZMK
that referenced
this pull request
Jan 16, 2024
* Fix SC2002 Shell Check warning * Fix SC2086 Shell Check warnings
zemackdaddy
pushed a commit
to zemackdaddy/Adv360-Pro-ZMK
that referenced
this pull request
Jan 22, 2024
* Fix SC2002 Shell Check warning * Fix SC2086 Shell Check warnings
tricktux
pushed a commit
to tricktux/Adv360-Pro-ZMK
that referenced
this pull request
Feb 10, 2024
* Fix SC2002 Shell Check warning * Fix SC2086 Shell Check warnings
ztomer
pushed a commit
to ztomer/Adv360-Pro-ZMK
that referenced
this pull request
Apr 16, 2024
* Fix SC2002 Shell Check warning * Fix SC2086 Shell Check warnings
zemackdaddy
pushed a commit
to zemackdaddy/Adv360-Pro-ZMK
that referenced
this pull request
Jul 7, 2024
* Fix SC2002 Shell Check warning * Fix SC2086 Shell Check warnings
jan-l
pushed a commit
to jan-l/Adv360-Pro-ZMK
that referenced
this pull request
Aug 28, 2024
* Fix SC2002 Shell Check warning * Fix SC2086 Shell Check warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
SC2002
-- pipingcat
through twogrep
calls may instead be handled all by onegrep
call within both the GitHub Action configuration, and build script.SC2086
-- double quoting prevents unintentional word splitting were one to call script withTIMESTAMP
defined, exTIMESTAMP="questionable idea" ./bin/build.sh
Related documentation
GitHub Action