-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bluetooth settings in light of user feedback #289
Update bluetooth settings in light of user feedback #289
Conversation
Should address #282 |
* upstream/V3.0: Update bluetooth settings in light of user feedback (KinesisCorporation#289) Revert "Add version macro to keymap.json (KinesisCorporation#269)" Add version macro to keymap.json (KinesisCorporation#269) Changelog new base ZMK update (KinesisCorporation#268) Version compiled FW with automatic macro (KinesisCorporation#267) Document new NKRO settings (KinesisCorporation#264) Improve documentation based on feedback (KinesisCorporation#260) Update reset file Update ZMK (KinesisCorporation#248) Further documentation work (KinesisCorporation#241) Fix shell check warnings (KinesisCorporation#242) Readme rewrite (KinesisCorporation#222) Add CHANGELOG (KinesisCorporation#221)
Can you list what the changes actually do and affect? Will commenting out |
@gshpychka The bluetooth LE connection parameters have been changed to improve compatibility with macOS. setting CONFIG_BT_PRIVACY=n is functionally the same as commenting it out so nothing has changed in that regard |
Understood, thanks. Still, can you clarify what those settings did and what exactly changed? |
The settings controlled some low level parameters of the Bluetooth connection. They were set according to the apple accessory device specification at the time. A few months ago Apple revised the accessory specification and we changed our settings accordingly |
# By ReFil (7) and others # Via GitHub * upstream/v3.0: Update Makefile variables (KinesisCorporation#335) Base ZMK update (KinesisCorporation#326) Prefer `tr` to ${char^^}, which does not work on older bash versions (KinesisCorporation#303) Add version macro (KinesisCorporation#300) Add pull request template (KinesisCorporation#293) Revert "Updated keymap" Revert "Updated keymap" Updated keymap Updated keymap Make get_version use bash from $PATH (KinesisCorporation#287) Update bluetooth settings in light of user feedback (KinesisCorporation#289) # Conflicts: # Makefile
* feat: update keymap * Update bluetooth settings in light of user feedback (KinesisCorporation#289) * Make get_version use bash from $PATH (KinesisCorporation#287) * Make get_version use bash from $PATH * Update CHANGELOG.md --------- Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com> * Updated keymap * Updated keymap * Revert "Updated keymap" This reverts commit 18e664a. * Revert "Updated keymap" This reverts commit 9fc6c62. * Add pull request template (KinesisCorporation#293) * Add pull request template * Update CHANGELOG.md * Add version macro (KinesisCorporation#300) * Prefer `tr` to ${char^^}, which does not work on older bash versions (KinesisCorporation#303) * Prefer `tr` to ${char^^}, which does not work on older bash versions * Update CHANGELOG.md --------- Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com> * Base ZMK update (KinesisCorporation#326) * Update Makefile variables (KinesisCorporation#335) * Makefile enhancements to optimize local workflows (KinesisCorporation#363) - Enhance the Makefile to enable firmware building exclusively for the left side. To modify the keymap, flashing only the left side's firmware suffices. This change facilitates the creation of firmware for the left side only, thereby expediting the build process. Usage: make left This update maintains existing functionality. Without specifying the left target, firmware for both halves will be generated. - Add separate make targets to clean firmware and docker image Add targets clean_firmware and clean_image independently while maintaing clean to run both - Ensure files modified by the build process are reset at the end The current build process dynamically generates the content of the version macro in config/version.dtsi to enable users to print out the precise version and commit the firmware was built on via a keybinding on the keymap. This change ensurs that the changes to this macro file are reset at the end of the build process to ensure it isn't shown as modified and added to keymap commit changes. * feat: add f keys --------- Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com> Co-authored-by: David Whetstone <humblehacker@users.noreply.github.com> Co-authored-by: adv360proapp[bot] <105741512+adv360proapp[bot]@users.noreply.github.com> Co-authored-by: Jim Jowdy <jjowdy@gmail.com> Co-authored-by: Thomas Huber <113915837+huber-th@users.noreply.github.com>
* V3.0: (57 commits) Fix version.dtsi is reset after local firmware build (KinesisCorporation#385) Update build workflows (KinesisCorporation#376) Makefile enhancements to optimize local workflows (KinesisCorporation#363) Update Makefile variables (KinesisCorporation#335) Base ZMK update (KinesisCorporation#326) Prefer `tr` to ${char^^}, which does not work on older bash versions (KinesisCorporation#303) Add version macro (KinesisCorporation#300) Add pull request template (KinesisCorporation#293) Revert "Updated keymap" Revert "Updated keymap" Updated keymap Updated keymap Make get_version use bash from $PATH (KinesisCorporation#287) Update bluetooth settings in light of user feedback (KinesisCorporation#289) Revert "Add version macro to keymap.json (KinesisCorporation#269)" Add version macro to keymap.json (KinesisCorporation#269) Changelog new base ZMK update (KinesisCorporation#268) Version compiled FW with automatic macro (KinesisCorporation#267) Document new NKRO settings (KinesisCorporation#264) Improve documentation based on feedback (KinesisCorporation#260) ...
No description provided.