Remove typeInfo struct from lmms_basics.h
#7380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rossmaxx
commented
Jul 15, 2024
Rossmaxx
commented
Jul 15, 2024
sakertooth
reviewed
Jul 19, 2024
Co-authored-by: saker <sakertooth@gmail.com>
sakertooth
approved these changes
Jul 20, 2024
I too thought the same, and asked gpt. It said it's exponential. |
Rossmaxx
commented
Jul 21, 2024
|
This PR is now ready. |
|
I'll merge this in 2 days if no one objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typeInfo struct mostly consists of functions which are already a part of the standard math library, and for the other 2 functions, they should belong in
lmms_math.h