-
-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove typeInfo
struct from lmms_basics.h
#7380
Conversation
Co-authored-by: saker <sakertooth@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for now, though there might be other thoughts. Apologies for thinking the exponential was subtraction and effectively suggesting how to break the build (might be getting a bit rusty, I should review the language again).
I too thought the same, and asked gpt. It said it's exponential. |
This PR is now ready. |
I'll merge this in 2 days if no one objects. |
The typeInfo struct mostly consists of functions which are already a part of the standard math library, and for the other 2 functions, they should belong in
lmms_math.h