-
-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup lmms_math.h
#7382
Cleanup lmms_math.h
#7382
Conversation
Co-authored-by: saker <sakertooth@gmail.com>
I would like to wait for #7380 before this PR. |
I have decided to clean up more mathematical stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to add, Dom covered most of what needed to be said already.
@DomClark we good for merge? I'm waiting for your nod. |
Did you plan to use |
No i said I'm not sure about the sign. There's chances negative values might be used. I don't wanna take much chances. |
There isn't - lmms/plugins/Sf2Player/Sf2Player.cpp Lines 760 to 765 in 35f350e
|
A bit late but thanks for the info. I'll keep it in mind for the future. |
* simplified fraction and absfraction functions * removed unused fastSqrt() and fastPow() functions * unused absMin() and absMax() * move roundAt to math header * Code review from saker Co-authored-by: saker <sakertooth@gmail.com> * use std::trunc() * fixup after fixing merge conflicts * remove unused fastFma and fastFmal functions. * remove lmms_basics include, not needed * use signedPowf from lmms_math in NES * removed fastRand function, unused * remove unused sinc function * cleanup signedPowf * code review * further simplify random number math * removed static from lmms_math file --------- Co-authored-by: saker <sakertooth@gmail.com>
Cleaned up some legacy code from
lmms_math.h