-
-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZynAddSubFx filter frequency set to 127 #7381
Conversation
Would it be, by any chance, nicer to set the default wave to Power instead of Sine as well? |
I've noticed that the plugin still treats the filter frequency knob as if it were set to 64. Only when the knob is moved does the change happen. |
Here a link to an MMPZ file proving that this even stays after saving. Will investigate further. |
I've saved the MMPZ as an MMP and am reading it. The first XML entry after each
The first two have had their "Filter frequency" knobs moved (indicated by |
connect( &m_filterFreqModel, SIGNAL( dataChanged() ), this, SLOT( updateFilterFreq() ), Qt::DirectConnection ); This would explain why a change to the knob pointed to by
GEN_CC_SLOT(updateFilterFreq,C_filtercutoff,m_filterFreqModel); The void ZynAddSubFxInstrument::updateFilterFreq() {
sendControlChange( C_filtercutoff, m_filterFreqModel.value() );
m_modifiedControllers[C_filtercutoff] = true;
} A hacky approach would be to call |
Indeed, in the same file, in |
Found the root! It's in |
Didn't you want to upgrade the submodule? You can reference it right now, assuming we will likely do an FF-merge in the zyn repo. |
Could you point me to some resource regarding that? I'm failing to understand how I could do that, given that the "zynaddsubfx" PR is not merged. |
After trying, I was unable to update the LMMS zynaddsubfx submodule. Is it possible for someone more experienced to assist me with this? |
IMO, you should wait till the other PR is merge. |
Likewise, zynaddsubfx first, then update the submodule, then merge this. |
This should work (if not we can still fix later):
|
Attempting to use the method you described prompted me with To elaborate further, checking out was not possible, because my changes to zynaddsubfx weren't yet approved. I tried using I ended up using My assumption is that, if the zynaddsubfx changes are excepted, then I can update the lmms submodule accordingly. The zynaddsubfx repo is waiting on your approval. |
My fork of LMMS is now pointing to the master commit of my fork of Zyn! |
Sorry, I forgot that this requires switching the forks. It is not good to set the URL of the submodule to your fork, because in the end, it should point to ours. I now pushed branch |
That should be it! Here's a link to the tree, to make things easier! |
This PR seems buggy. I do this:
Observations:
Can this be confirmed? Or did I do anything wrong? At least, the behavior is correct on branch |
Your statements are correct, the change in the frequency relating to LMMS is only in regard to the FREQ knob in the Zyn LMMS UI (red box in the image at the top). Lost checked that 100 is the best value for the ADDSynth, SUBSynth and PADSynth filter, as it makes sense in the context of automation as well as not making the signal lowpassed, so I set them to 100. The change that should be noticed is that none of the synths are lowpassed, as was the case previously. The change to ADD-, SUB- and PADSynth is in the zynaddsubfx repo, of course. |
I don't understand. Can you reproduce my issue? If yes, IMO this should be fixed. I can't imagine that Lost planned that? |
I'll try to explain. By default, Zyn's synths are lowpassed, with Add having a filterfreq vaule of 94, IIRC. Understandably, having the signal lowpassed implies that the signal has been edited from the standard sine wave before you did anything. I aimed to correct that. Initially, I set all the filterfreq's to 127, but Lost pointed out that that would not allow for neatly automating the signal, as made evident by these Discord messages:
I did as Lost suggested, which is what the two PRs I made are. Tres made it clear that this is changed in Zyn-Fusion, so this is simply a small patch to make Zyn more user-friendly until it's is updated. |
This should now really be it! Both here and in the Zyn repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing and Code OK.
While awaiting the latest build, can you please formulate a commit message for squash? Like
one-line description
<empty line>
optional
longer
description
Thanks.
In this repo, the only changes made are updating the according submodule and changing the FREQ knob in ZynAddSubFx's LMMS GUI.
Same as in the other repo, I am terribly sorry for misunderstanding your comment.
|
After the Zyn PR is merged, the submodule here has to be updated, after which this can be merged as well. |
OK, please update the submodule reference now. |
I think that went wrong? I guess it should point to 9499523f70322b6034673566898300e7543fdf3e now, because this is the repo's master? |
I believe it does, here's the tree of my fork. |
Now I see it, thanks. |
I'm tying this PR to the ZynAddSubFX PR #23. These two PRs aim to disable the default lowpass filter applied to Zyn's three synths, as well as keeping the possibility of filter automation without affecting Zyn internally.
There is only one change in this PR specifically, that being that the filter frequency is set to the maximum value of 127, as per Lost Robot's suggestion in the Discord server.