Filter frequency of all three synths set to 100 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @LostRobotMusic and @JohannesLorenz as reviewers. |
LostRobotMusic
approved these changes
Jul 15, 2024
|
To completely disable the lowpass, the default value of the MIDI controller for the filter cutoff should be moved to a value of 127. This makes the filter knob in the Zyn LMMS UI work as well, both manually and through automation, since it just updates the MIDI controller. |
JohannesLorenz
approved these changes
Jul 19, 2024
In this repo, the synths (ADD, SUB and PAD) have had the filter frequency changed to 100. Controller defaults have also been changed (filtercutoff.depth).
|
I'm sorry for misunderstanding your comment. The commit message here is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add to #22, the filter frequency of ADD, SUB and PAD have all been set to 100.
In LMMS, the filter frequency has been set to 127, the maximum value. This, according to Lost, allows for automating the filter as well as disabling the lowpass which happens by default.
The linked PR in LMMS is here.