Feat(CN-472): add category filter with discover category deeplink param #7565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
live-github-bot
bot
added
desktop
beths-ledger
commented
Aug 8, 2024
| /** e.g. "all", "restaking", "services", etc */ | ||
| export type CategoryId = Categories["selected"]; | ||
|
|
||
| export function useCategories(manifests, initialCategory?: CategoryId): Categories { |
There was a problem hiding this comment.
@marcotoniut-ledger this will be needed for the LLM route
beths-ledger
changed the title
Justkant
requested changes
Aug 9, 2024
apps/ledger-live-desktop/src/renderer/screens/platform/v2/Catalog/Browse/Search.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/screens/platform/v2/Catalog/index.tsx
Outdated
Show resolved
Hide resolved
beths-ledger
force-pushed
the
feat/live-cn-472-category-param-deeplink-filter-on-discover
branch
from
d0c6a46
to
369af50
Compare
Justkant
reviewed
Aug 9, 2024
apps/ledger-live-desktop/src/renderer/screens/platform/v2/Catalog/index.tsx
Outdated
Show resolved
Hide resolved
Justkant
reviewed
Aug 9, 2024
apps/ledger-live-desktop/src/renderer/screens/platform/v2/Catalog/index.tsx
Outdated
Show resolved
Hide resolved
Justkant
approved these changes
Aug 9, 2024
beths-ledger
force-pushed
the
feat/live-cn-472-category-param-deeplink-filter-on-discover
branch
from
a64493b
to
b6f0b38
Compare
gre
approved these changes
Aug 12, 2024
3 tasks
beths-ledger
deleted the
feat/live-cn-472-category-param-deeplink-filter-on-discover
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Add discover section deep link initial category filter to enable links like ledgerlive://discover?category=restaking to load the discover section with an initial category pre-selected.
This is required for the new "restaking" banner on earn dashboard.
Routes with a discover platform app id will not be impacted.
ledgerlive://discover?category=restaking
❓ Context
🧐 Checklist for the PR Reviewers