Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CN-476): add category param filter to llm platform discover section #7580

Conversation

marcotoniut-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • MOBILE ONLY: ledgerlive://discover?restaking should load discover section with "Restaking" tagged platforms pre-filtered.
    • Other categories should filter by those categories invalid category does not return any results

📝 Description

Add discover section deep link initial category filter to enable links like ledgerlive://discover?category=restaking to load the discover section with an initial category pre-selected.

This is required for the new "restaking" banner on earn dashboard.

Routes with a discover platform app id will not be impacted.

Screenshot 2024-08-12 at 15 16 57

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@marcotoniut-ledger marcotoniut-ledger requested a review from a team as a code owner August 12, 2024 15:12
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Aug 13, 2024 10:16am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 10:16am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 10:16am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 10:16am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 10:16am

@live-github-bot live-github-bot bot added mobile Has changes in LLM common Has changes in live-common labels Aug 12, 2024
Justkant
Justkant previously approved these changes Aug 12, 2024
Copy link
Contributor

@Justkant Justkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you might want to sync with the merge of this PR as you have almost the same modifications as this PR: #7565

@marcotoniut-ledger
Copy link
Contributor Author

@Justkant would you say its safe to merge this?

@Justkant
Copy link
Contributor

Justkant commented Aug 14, 2024

@Justkant would you say its safe to merge this?

Yes that's why I approved 😄

@marcotoniut-ledger marcotoniut-ledger merged commit 63e4fdc into develop Aug 14, 2024
35 of 37 checks passed
@marcotoniut-ledger marcotoniut-ledger deleted the CN-476-add-category-param-filter-to-llm-platform-discover-section branch August 14, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants