vstest to honor nologo input from dotnet.exe #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smadala
approved these changes
Aug 3, 2018
| @@ -93,7 +93,16 @@ internal int Execute(params string[] args) | |||
| { | |||
| this.testPlatformEventSource.VsTestConsoleStart(); | |||
|
|
|||
| this.PrintSplashScreen(); | |||
| // If User specifies --nologo via dotnet, donot print splat screen | |||
| if (args != null && args.Length !=0 && args.Contains("--nologo")) | |||
There was a problem hiding this comment.
Move this logic to function.
There was a problem hiding this comment.
we are controlling this argument, can make case insensitive, but didn't need it now
| @@ -87,6 +88,7 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <Message Text="VSTestCollect = $(VSTestCollect)" Importance="low" /> | |||
| <Message Text="VSTestBlame = $(VSTestBlame)" Importance="low" /> | |||
| <Message Text="VSTestTraceDataCollectorDirectoryPath = $(TraceDataCollectorDirectoryPath)" Importance="low" /> | |||
| <Message Text="VSTestNoLogo = $(VSTestNoLogo)" Importance="low" /> | |||
There was a problem hiding this comment.
Create corresponding PR in dotnet cli repo.
| @@ -93,7 +93,16 @@ internal int Execute(params string[] args) | |||
| { | |||
| this.testPlatformEventSource.VsTestConsoleStart(); | |||
|
|
|||
| this.PrintSplashScreen(); | |||
| // If User specifies --nologo via dotnet, donot print splat screen | |||
| if (args != null && args.Length !=0 && args.Contains("--nologo")) | |||
There was a problem hiding this comment.
Should we support /nologo? Reference https://msdn.microsoft.com/en-us/library/ms164311.aspx
There was a problem hiding this comment.
we are not supporting this as first class argument yet, only if it comes from dotnet cli, & from dotnet cli it will always come as --nologo. I don't want to add additional checks for something we are not supporting
This was referenced Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VSTest should honor /nologo user input from dotnet cli.
However we are not exposing it as first class argument for vstest.console CLI
dotnet/cli repo dotnet/cli#9791
Related issue
Fixes #1701.