Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swiper from 6.8.4 to 11.0.7 #11968

Merged
merged 5 commits into from
Apr 1, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 4, 2024

Bumps swiper from 6.8.4 to 11.0.7.

Release notes

Sourced from [swiper's releases](https://github.com/nolimits4web/Swiper/releases).

v11.0.7

Bug Fixes

Features

v11.0.6

Bug Fixes

Features

v11.0.5

Bug Fixes

Features

  • core: new slidesUpdated event ([8a0c7c4](https://github.com/nolimits4web/Swiper/commit/8a0c7c43ad5931d22a20a9b33152f6befc5bcb59))

v11.0.4

Bug Fixes

v11.0.3

Bug Fixes

v11.0.2

... (truncated)

Changelog

Sourced from [swiper's changelog](https://github.com/nolimits4web/swiper/blob/master/CHANGELOG.md).

[11.0.7](https://github.com/nolimits4web/Swiper/compare/v11.0.6...v11.0.7) (2024-02-27)

Bug Fixes

Features

[11.0.6](https://github.com/nolimits4web/Swiper/compare/v11.0.5...v11.0.6) (2024-02-05)

Bug Fixes

Features

[11.0.5](https://github.com/nolimits4web/Swiper/compare/v11.0.4...v11.0.5) (2023-11-22)

Bug Fixes

Features

  • core: new slidesUpdated event ([8a0c7c4](https://github.com/nolimits4web/Swiper/commit/8a0c7c43ad5931d22a20a9b33152f6befc5bcb59))

[11.0.4](https://github.com/nolimits4web/Swiper/compare/v11.0.3...v11.0.4) (2023-11-09)

Bug Fixes

[11.0.3](https://github.com/nolimits4web/Swiper/compare/v11.0.2...v11.0.3) (2023-10-26)

Bug Fixes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

┆Issue is synchronized with this Jira Task

@dependabot dependabot bot added dependencies Pull requests that update a dependency file engineering labels Mar 4, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/swiper-11.0.7 branch 10 times, most recently from 490c01f to 8eaaff6 Compare March 9, 2024 02:29
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/swiper-11.0.7 branch 8 times, most recently from 3b5df3c to 7358515 Compare March 18, 2024 13:57
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/swiper-11.0.7 branch 9 times, most recently from fd0a7d2 to 98dc1ea Compare March 21, 2024 22:17
@mmmavis mmmavis self-assigned this Mar 21, 2024
@mmmavis mmmavis self-requested a review March 21, 2024 22:18
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/swiper-11.0.7 branch 3 times, most recently from af30fb1 to 0bd1857 Compare March 26, 2024 22:58
Bumps [swiper](https://github.com/nolimits4web/Swiper) from 6.8.4 to 11.0.7.
- [Release notes](https://github.com/nolimits4web/Swiper/releases)
- [Changelog](https://github.com/nolimits4web/swiper/blob/master/CHANGELOG.md)
- [Commits](nolimits4web/swiper@v6.8.4...v11.0.7)

---
updated-dependencies:
- dependency-name: swiper
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/swiper-11.0.7 branch from 0bd1857 to fc2f842 Compare March 26, 2024 23:43
@mmmavis
Copy link
Collaborator

mmmavis commented Mar 27, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 27, 2024

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@mmmavis
Copy link
Collaborator

mmmavis commented Mar 28, 2024

Hey @robdivincenzo ,

I had to push a few commits to this PR to address breaking changes introduced along the way from swiper v6.8.4 to v11.0.7. It looks like we haven't updated this package for 2-3 years which makes the loooooooooooong changelog hard to get through 😂 I've left some comments regarding the code changes I added in. Please let me know if I can clarify anything further. Thanks!

To test

  • Go to this page on review app and scroll to the slider section (see screenshot below)
  • Click on the arrow keys to see if they work as expected and doesn't create any console errors. (For comparison, this is what we have on prod)
image

@mmmavis mmmavis temporarily deployed to foundation-s-dependabot-wnzrqz March 28, 2024 19:30 Inactive
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 1, 2024

A newer version of swiper exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Copy link
Collaborator

@robdivincenzo robdivincenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmmavis LGTM! Great work digging through years of changelog to get that updated 😅

@mmmavis mmmavis temporarily deployed to foundation-s-dependabot-wnzrqz April 1, 2024 16:32 Inactive
@mmmavis mmmavis merged commit 52b07be into main Apr 1, 2024
6 checks passed
@mmmavis mmmavis deleted the dependabot/npm_and_yarn/swiper-11.0.7 branch April 1, 2024 17:00
@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

PR has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file engineering run visual regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants