Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add Optional swiperElementNodeName Prop for (non swiper-element) Web Component Usage #7284

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

sghoweri
Copy link
Contributor

Our design system team recently ran into some major rendering issues using Swiper internally with some of our LitElement based web components (slotted children slides aren't detected).

After doing some digging, I stumbled across the change added in #6870 which uses a hard-coded nodeName to ultimately determine if a particular swiper instance is rendering as a web component or not.

This PR should allow continued Swiper usage (as-is) via the swiper-container custom element, yet also help other folks with customized web component usage by using this new swiperElementNodeName parameter to define the custom element tag name being used in their implementation.

@nolimits4web nolimits4web merged commit 178511f into nolimits4web:master Feb 5, 2024
@nolimits4web
Copy link
Owner

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants