Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hasklig: 1.1 -> 1.2 #135938

Closed
wants to merge 1 commit into from
Closed

hasklig: 1.1 -> 1.2 #135938

wants to merge 1 commit into from

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Latest updates

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Profpatsch August 27, 2021 17:03
Atemu
Atemu reviewed Aug 27, 2021
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is everything under a hasklig/ dir now?

@NeQuissimus
Copy link
Member Author

@Atemu They switched around the structure of the archives, not sure about reasoning.

@NeQuissimus NeQuissimus closed this Oct 4, 2021
@NeQuissimus NeQuissimus deleted the hasklig_1_2 branch October 4, 2021 16:07
@georgefst
Copy link
Contributor

Why was this closed? I was looking forward to 1.2 due to i-tu/Hasklig#123.

@NeQuissimus
Copy link
Member Author

I closed this because the font was not working right for me and I do not have the time to investigate. You are welcome to submit a new PR

@georgefst
Copy link
Contributor

georgefst commented Oct 8, 2021 •
edited
Loading

I closed this because the font was not working right for me

In what way, out of interest? It's working fine for me on MacOS Big Sur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemu Atemu Atemu left review comments

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeQuissimus @georgefst @Atemu