Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No color on macOS Big Sur #123

Closed
balupton opened this issue Nov 13, 2020 · 22 comments
Closed

No color on macOS Big Sur #123

balupton opened this issue Nov 13, 2020 · 22 comments

Comments

@balupton
Copy link

@foxt
Copy link

foxt commented Nov 13, 2020

This seems to be an issue with a SVG table, we need someone to remove those from Hasklig to regain support

@patricklewis
Copy link

Took me a while to identify the font as the source of this "no text color" problem in Visual Studio Code after upgrading to Big Sur today.

@hisham-blackbuck
Copy link

any workarounds for this? Reinstalling Hasklig did not fix the issue, and while disabling Hasklig is the only workaround now, my code looks bland without Hasklig 😢

@thedocbwarren
Copy link

Would love a solution. Appears other fonts work that have ligatures.

@1moeses
Copy link

1moeses commented Nov 17, 2020

Is there someone who can do a pull request. Unfortunally I'm not into python font coding stuff right now. The last commit was on Feb. 27, 2020.

@thedocbwarren
Copy link

Will need to build from the patched (remove SVG table) from Source Code Pro then add ligatures. I wish I did this these days as I use to make fonts, but not recently.

@labikmartin
Copy link

labikmartin commented Nov 18, 2020

any workarounds for this? Reinstalling Hasklig did not fix the issue, and while disabling Hasklig is the only workaround now, my code looks bland without Hasklig 😢

You can use Source Code Pro in the meantime.
Google Fonts

@hisham-blackbuck
Copy link

I believe Source Code Pro has slightly different ligatures. For example, the arrow function symbol is different. Correct me if I'm wrong here

@labikmartin
Copy link

I believe Source Code Pro has slightly different ligatures. For example, the arrow function symbol is different. Correct me if I'm wrong here

That font doesn't have ligatures. But other than that it looks the same :)

@hisham-blackbuck
Copy link

Oh then I'll have to wait till Hasklig fixes this, because I need those ligatures. I could try Fira Code in the meantime

@tovbinm
Copy link

tovbinm commented Dec 8, 2020

Switching to Source Code Pro worked - https://github.com/adobe-fonts/source-code-pro/releases/tag/2.032R-ro%2F1.052R-it%2F1.012R-VAR

Looking forward for a similar fix for Hasklig!

@thedocbwarren
Copy link

Looking at last update I'd say this might be unmaintained. Not sure how this font was generated from Source Code Pro.
I'm going to guess this could be from a script that merged ligatures from Fira Code.

@jonboiser
Copy link

This repo is a fork of the original Source Code Pro repo. You can see in a commit like this one fe063b4 one of the last updates from the upstream repo.

I'm not sure how these updates were done, but it might be possible to update to the latest SCP source, and run the build scripts.

@ehrlichja
Copy link

I fixed this problem on my Big Sur installation. I deleted Haskling from Font Book and re-installed it using Brew.

The problem was only showing up in Alacritty for me, but the above steps fixed it.

@tovbinm
Copy link

tovbinm commented Dec 12, 2020

@ehrlichja That did not work for me.

@thedocbwarren
Copy link

thedocbwarren commented Dec 14, 2020

It doesn't work for anybody. Hasklig needs to be updated directly with the fixes to remove invalid SVG gliffs.

@georgefst
Copy link

Source Code Pro has removed the SVG table. I think the same fix is in order here.

If no one else steps up, I'll have a look at opening a PR porting the fix. But it might be easier for someone who already knows anything about creating fonts.

@thedocbwarren
Copy link

Agreed, I'm not 100% sure what is needed but can look as well.

pkq added a commit to pkq/Hasklig that referenced this issue Dec 17, 2020
Remove the (experimental) SVG table to enable color-coded text on macOS Big Sur (Issue i-tu#123), following the approach implemented in upstream Source Code Pro (adobe-fonts/source-code-pro#255). See upstream issue (adobe-fonts/source-code-pro#250) for additional details.

Refactor build.sh to be more robust, consistent with revisions to upstream code
@pkq
Copy link

pkq commented Dec 17, 2020

Font development is well outside my comfort zone, but I believe this issue is resolved by #125. Until these changes are merged, you should be able to build the font from source using the SVGpatch branch and the directions in the README.md.

@mbg
Copy link

mbg commented Dec 22, 2020

#125 / v1.2 have resolved this issue for me on Big Sur.

@i-tu
Copy link
Owner

i-tu commented Dec 22, 2020

Thank you @pkq for looking into this, and thanks @mbg for confirming it works 👍

The new release can be downloaded here: https://github.com/i-tu/Hasklig/releases/tag/v1.2

Do let me know if you have any issues.

Happy winter solstice and related festivities to all! :)

@i-tu i-tu closed this as completed Dec 22, 2020
@jonboiser
Copy link

I've submitted a PR to update the homebrew cask for this font (my preferred installation method)

Homebrew/homebrew-cask-fonts#3301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests