Remove SVG table to enable color-coded text on macOS Big Sur #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make DesignSpace files compliant with current specification (https://github.com/fonttools/fonttools/tree/master/Doc/source/designspaceLib) and resolve the 'No axes defined' error when building the font from source. axisDescriptors copied from upstream Source Code Pro (https://github.com/adobe-fonts/source-code-pro/blob/master/Roman/Masters/SourceCodePro.designspace) Issue i-tu#114
Remove the (experimental) SVG table to enable color-coded text on macOS Big Sur (Issue i-tu#123), following the approach implemented in upstream Source Code Pro (adobe-fonts/source-code-pro#255). See upstream issue (adobe-fonts/source-code-pro#250) for additional details. Refactor build.sh to be more robust, consistent with revisions to upstream code
|
Hey @pkq , HUGE thanks for working on this PR. I checked it out and got inspired to start working on this myself too. I don't think I would have gotten around to it if it weren't for your enthusiasm! I have rebased the entire repository on top of the latest Source Code Pro repository, incorporating all the progress made there. These changes are now in a new default branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the (experimental) SVG table to enable color-coded text on macOS Big Sur (Issue #123), following the approach implemented in upstream Source Code Pro (adobe-fonts/source-code-pro#255). See upstream issue (adobe-fonts/source-code-pro#250) for additional details.
Once merged, changes will require a new build and corresponding updates to README.md, etc.