10.0 mig currency rate update #415
Conversation
Update README Code cleanup: remove @api.one, better error messages, remove call to MOD_NAME which was not defined any more Use account.menu_config_multi_currency as parent menu
|
I improved this PR and made a PR to niki's branch nikiwaibel#1 |
…ll_mig_improvements 10.0 Improve your PR to port currency_rate_update to v10
There was a problem hiding this comment.
👍 Code review and test with Yahoo Finance and ECB.
Just one question: I see that all res.currency.rates records are set as 00:00:00 time (actually 01:00:00 in my case because of the timezone, which may be a little bug), is there a reason why we can't have multiple rates per day, assuming one executes the rate updater manually?
|
I get a crash when I try to add "currencies to update with this service": |
|
I think we need the same kind of fix for the bug I talked about in my previous comment than the one I made for the module account_payment_order in OCA/bank-payment: |
|
Here is my PR to fix the bug nikiwaibel#2 |
[FIX] Crash when you add currencies to "Currencies to update with this service"
|
Hey @nikiwaibel, Appreciation of efforts, |
|
@nikiwaibel Have you signed OCA's CLA, or it is just an error of the bot ? |
|
i signed it - some months ago :-)
…On Wed, Apr 5, 2017 at 11:46 AM, Alexis de Lattre ***@***.***> wrote:
@nikiwaibel <https://github.com/nikiwaibel> Have you signed OCA's CLA, or
it is just an error of the bot ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#415 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAhct4t8EJKtJ2NpLB2GLxCQOX679Z7Dks5rs2L5gaJpZM4Ki0nF>
.
|
|
The crash I reported 7 days ago and fixed a few days ago was caused by this bug in odoo: odoo/odoo#16072 |
|
Fix for multi-company nikiwaibel#3 |
…ticompany [FIX] currency_rate_update should now work in multi-company
hi, this is my first pull request to OCA - hope it's all okay