[FIX] Bug #353 crash when selecting a payment mode that has a variable link to bank accounts #354
Conversation
…able link to a bank account
| @@ -162,10 +146,18 @@ def create(self, vals): | |||
| @api.onchange('payment_mode_id') | |||
| def payment_mode_id_change(self): | |||
| journal_id = False | |||
| res = {'domain': { | |||
| 'journal_id': "[('id', '=', False)]", | |||
There was a problem hiding this comment.
This should be {'journal_id': []}
There was a problem hiding this comment.
If I make your modification, then I have access to all journals when no payment mode is selected, which is not what I want : I want the user to select a payement mode first. So I prefer my solution, which works well.
There was a problem hiding this comment.
Then please hide the field when no payment mode is selected in the view via attrs attribute.
|
@alexis-via I think the onchange will not trigger when opening a previously saved payment order, so in that case, the domain will be wrong. Dynamic domains are a pain to get right... I think it's part of the reasons that pushed @lmignon to create OCA/web#567. You may want to try it. |
|
@sbidoul Very interesting, thanks ! |
|
I propose to merge this to avoid the crash. And then, if someone is able to propose a better solution, he will propose another PR. |
Cf bug #353 for a detailed scenario of the crash.
I you have better ideas to fix this bug, please propose. I suggests this solution because it's the only one I found that currently works on v10.