-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ocrd_pc_segmentation, move from tf21 to tf2 #264
Conversation
See ocr-d-modul-2-segmentierung/page-segmentation#4 for details. |
Damn. Placing ocrd_pc_segmentation in sub-venv/headless-tf2 creates another conflict around h5py (ocrd_calamari wants |
It's not ocrd_pc_segmentation's or ocr4all-pixel-classifier's fault: they simply allow running the most recent TF, which happens to be incompatible with current ocrd_calamari. Unfortunately, the latter does not advertise this dependency. (See fix for the latter here and analysis of the former here.) I see no way around this other than using different venvs for ocrd_calamari ( Unless anyone has a better idea? |
To summarize:
So, we need a new release of ocrd_calamari and the only remaining |
yes
yes
no, ocrd_calamari is already in headless-tf2, but it can stay there along with ocrd_pc_segmentation if ...
yes, the combination h5py<3 and TF<2.5 is overly restrictive, and prevents sharing the venv with ocrd_pc_segmentation. (We would need a tf24 venv for no gain.)
yes |
Ok, I have removed the h5py hack for headless-tf2 and switched to OCR-D/ocrd_calamari@76b34c5 now – let's see if it works. |
No. Seems like ocrd_pc_segmentation needs another fix. Let's see... |
To prevent pc_segmentation from dragging in TF 2.5 and thus invalidating that venv for other modules.