Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: prevent TF 2.5 #64

Merged
merged 1 commit into from
Jul 1, 2021
Merged

requirements: prevent TF 2.5 #64

merged 1 commit into from
Jul 1, 2021

Conversation

bertsky
Copy link
Contributor

@bertsky bertsky commented Jun 19, 2021

Since Tensorflow 2.5 is out (well, kind of, it's most recent on PyPI, but there's no GH release yet), which depends on h5py 3.1, model loading won't work anymore (or depending on the order of installation there will at least be an unresolved conflict around h5py).

@codecov-commenter
Copy link

Codecov Report

Merging #64 (2fd6e53) into master (da98713) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   88.75%   88.88%   +0.13%     
==========================================
  Files           2        3       +1     
  Lines         169      171       +2     
  Branches       38       38              
==========================================
+ Hits          150      152       +2     
  Misses         11       11              
  Partials        8        8              
Impacted Files Coverage Δ
ocrd_calamari/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da98713...2fd6e53. Read the comment docs.

@kba
Copy link
Member

kba commented Jun 21, 2021

Is this still necessary in light of ocr-d-modul-2-segmentierung/page-segmentation#4 (comment) ?

@bertsky
Copy link
Contributor Author

bertsky commented Jun 21, 2021

Is this still necessary in light of ocr-d-modul-2-segmentierung/page-segmentation#4 (comment) ?

Yes, it is, because of that. See situation in ocrd_all.

@mikegerber mikegerber self-assigned this Jul 1, 2021
Copy link
Collaborator

@mikegerber mikegerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikegerber mikegerber merged commit fcd4aba into OCR-D:master Jul 1, 2021
@mikegerber
Copy link
Collaborator

Sorry for this taking a few days, I somehow overlooked the mail notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants