Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: generateInitContainerDef added additional env and resources #963

Merged

Conversation

k3mahesh
Copy link
Contributor

@k3mahesh k3mahesh commented Jun 3, 2024

test: generateInitContainerDef added additional env and resources

Signed-off-by: Mahesh Kumar <k.mahesh.9779@gmail.com>
Signed-off-by: Mahesh Kumar <k.mahesh.9779@gmail.com>
@drivebyer
Copy link
Collaborator

@k3mahesh, thank you for your contribution! Could you please help us by resolving the conflict?

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.13%. Comparing base (d121d86) to head (87bf99f).
Report is 64 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
+ Coverage   35.20%   41.13%   +5.93%     
==========================================
  Files          19       20       +1     
  Lines        3213     2674     -539     
==========================================
- Hits         1131     1100      -31     
+ Misses       2015     1503     -512     
- Partials       67       71       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer changed the title Generate init container def test test: generateInitContainerDef added additional env and resources Jun 5, 2024
@drivebyer drivebyer enabled auto-merge (squash) June 5, 2024 02:02
@drivebyer drivebyer merged commit 96a5ccf into OT-CONTAINER-KIT:master Jun 5, 2024
28 of 29 checks passed
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
…-CONTAINER-KIT#963)

* test: cover generateInitContainerDef

Signed-off-by: Mahesh Kumar <k.mahesh.9779@gmail.com>

* test: generateInitContainerDef added additional env and resources

Signed-off-by: Mahesh Kumar <k.mahesh.9779@gmail.com>

---------

Signed-off-by: Mahesh Kumar <k.mahesh.9779@gmail.com>
Signed-off-by: Matt Robinson <mattrobinsonsre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants