Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: generateInitContainerDef added additional env and resources #963

Merged
merged 3 commits into from
Jun 5, 2024
Merged

test: generateInitContainerDef added additional env and resources #963

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
878fa11
test: cover generateInitContainerDef
k3mahesh Apr 22, 2024
46b5233
test: generateInitContainerDef added additional env and resources
k3mahesh Jun 3, 2024
87bf99f
Merge branch 'master' into generateInitContainerDef-test
k3mahesh Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 42 additions & 6 deletions k8sutils/statefulset_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"github.com/stretchr/testify/assert"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
v1 "k8s.io/api/core/v1"
kerrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand Down Expand Up @@ -688,31 +689,66 @@ func TestGenerateContainerDef(t *testing.T) {
func TestGenerateInitContainerDef(t *testing.T) {
tests := []struct {
name string
initContainerName string
initContainerDef initContainerParameters
expectedInitContainerDef []corev1.Container
mountPaths []corev1.VolumeMount
}{
{
name: "Redis",
name: "Test1_With_Resources_AdditionalENV",
initContainerName: "redis",
initContainerDef: initContainerParameters{
Image: "redis-init-container:latest",
ImagePullPolicy: corev1.PullAlways,
Command: []string{"/bin/bash", "-c", "/app/restore.bash"},
PersistenceEnabled: ptr.To(false),
Resources: &corev1.ResourceRequirements{
Requests: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("220m"),
v1.ResourceMemory: resource.MustParse("500Mi"),
},
Limits: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("250m"),
v1.ResourceMemory: resource.MustParse("500Mi"),
},
},
AdditionalEnvVariable: &[]v1.EnvVar{
{
Name: "TLS_MODE",
Value: "true",
},
},
},
expectedInitContainerDef: []corev1.Container{
{
Name: "initRedis",
Name: "initredis",
Image: "redis-init-container:latest",
Command: []string{"/bin/bash", "-c", "/app/restore.bash"},
ImagePullPolicy: corev1.PullAlways,
VolumeMounts: getVolumeMount("redisVolume", ptr.To(false), false, false, nil, []corev1.VolumeMount{}, nil, nil),
Resources: corev1.ResourceRequirements{
Requests: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("220m"),
v1.ResourceMemory: resource.MustParse("500Mi"),
},
Limits: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("250m"),
v1.ResourceMemory: resource.MustParse("500Mi"),
},
},
Env: []v1.EnvVar{
{
Name: "TLS_MODE",
Value: "true",
},
},
},
},
mountPaths: []corev1.VolumeMount{},
},
{
name: "Redis-1",
name: "Test2_With_Volume",
initContainerName: "redis",
initContainerDef: initContainerParameters{
Image: "redis-init-container:latest",
ImagePullPolicy: corev1.PullAlways,
Expand All @@ -721,11 +757,11 @@ func TestGenerateInitContainerDef(t *testing.T) {
},
expectedInitContainerDef: []corev1.Container{
{
Name: "initRedis-1",
Name: "initredis",
Image: "redis-init-container:latest",
Command: []string{"/bin/bash", "-c", "/app/restore.bash"},
ImagePullPolicy: corev1.PullAlways,
VolumeMounts: getVolumeMount("Redis-1", ptr.To(true), false, false, nil, []corev1.VolumeMount{
VolumeMounts: getVolumeMount("redis", ptr.To(true), false, false, nil, []corev1.VolumeMount{
{
Name: "Redis-1",
MountPath: "/data",
Expand All @@ -745,7 +781,7 @@ func TestGenerateInitContainerDef(t *testing.T) {
for i := range tests {
test := tests[i]
t.Run(test.name, func(t *testing.T) {
initContainer := generateInitContainerDef(test.name, test.initContainerDef, test.mountPaths)
initContainer := generateInitContainerDef(test.initContainerName, test.initContainerDef, test.mountPaths)
assert.Equal(t, initContainer, test.expectedInitContainerDef, "Init Container Configuration")
})
}
Expand Down
Loading