Update flywheel speeds #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettsummerfi3ld
requested review from
EuphoniumPlayer,
DLipovac93,
Mamapama and
ShaneHopkins11
|
@garrettsummerfi3ld did this work right? The only time that FLYWHEEL_MOTOR_REDUCED_SPEED is used is when button 12 is pressed, and the FLYWHEEL_MOTOR_SLOW_SPEED is what pushing down on the POV input uses, and from what I've been told that is what is supposed to put it in the dump bed and that is what the code for the flywheels is written for |
|
This was intended behavior from Andrew. I was the one that put it down and merged as Andrew approved it. |
|
Okay, just making sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Andrew, the flywheel speeds need to be slightly slower for the conveyor to get it into the dump without issues.