Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver Input Updates & Auth Mechanisms (UI & FW) #890

Merged
merged 39 commits into from
Mar 22, 2024

Conversation

arntsonl
Copy link
Contributor

@arntsonl arntsonl commented Mar 13, 2024

This is a big change to the already big driver inputs.

For this change, the big items are:

  • Authentication mechanisms are no longer handled by add-ons
  • Authenticated data storage is placed in input driver auth handler
  • Input Settings options have been added to the Web UI under "Settings"
  • New tab-based system for Settings
  • Keyboard Mapping page is removed in place of "Input Settings" Keyboard option
  • Separates PS4 and PS5 modes with their own separate auth mechanisms

Xbox 360 authentication is WIP and disabled in this PR, but will be picked up again after the release. We have too many good changes to go in, I don't want to hold us up anymore.

image15
Keyboard Mapping moved to input settings

image14
PS4 and PS5 timeout warnings if authentication is not set

image13
Upload Keys & USB auth settings in the PS4 and PS5 input settings separately. You can now save PS4 as key mode and PS5 as dongle mode

image12
X-Input and other settings have a message with no settings available (X-Input will have Xbox 360 auth dongle soon)

image11
Main page is set to tabs now instead of a long scrolling page

ImgBotApp and others added 30 commits February 5, 2024 07:38
*Total -- 6,536.44kb -> 6,081.92kb (6.95%)

/configs/OpenCore0/assets/Open_Core0_LED_order.png -- 81.87kb -> 34.77kb (57.53%)
/configs/OpenCore0/assets/Open_Core0_pin_mapping.png -- 79.46kb -> 34.15kb (57.02%)
/configs/OpenCore0/assets/Open_Core0_layout.png -- 80.33kb -> 34.76kb (56.73%)
/configs/OpenCore0/assets/Open_Core0_2.jpg -- 3,134.92kb -> 2,976.17kb (5.06%)
/configs/OpenCore0/assets/Open_Core0.jpg -- 3,159.87kb -> 3,002.07kb (4.99%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
[ImgBot] Optimize images
…ll to get USB driver if available.

Lots of other changes
…l/GP2040-CE into 20240217_inputauth_moved

# Conflicts:
#	src/gp2040aux.cpp
#	src/storagemanager.cpp
…rything over to drivers. This also removes the PS4Data global I've been using, and cleans all of that up to pointers and class storage variables.
… PS4 keys. PS4/PS5 modes shouuuuld work now on keys and USB separately
…d xbone pass through in JSX and webconfig.

This also auto-migrates users from 0.7.7 to 0.7.8 who had ps5 enabled using USB, including updating their boot modes and current input mode.

Small tweak to PS4 Driver to clarify controllerType is NOT the old saved ps4ControllerType protobuf variable.
@arntsonl arntsonl marked this pull request as ready for review March 20, 2024 19:41
…ntil we come up with a standard of any kind.
…r, defaulted to 0 instead of 500ms.

Updated board configs to follow convention for PS5 mode and add USB authentication where applicable.

USB block defines used instead of add-on config options.
Fixed a missing keyboard mapping sub-header in addons
…unction call for Xbox One.

Also fixed gpscreen to be an iterator loop to hopefully fix the .at(i) weirdness I'm getting.

Added back in tud vendor control function callback.
Copy link
Contributor Author

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for the big merge

@arntsonl arntsonl merged commit 8905b74 into OpenStickCommunity:main Mar 22, 2024
32 checks passed
@octopuserectus
Copy link

octopuserectus commented Apr 1, 2024

Keyboard keys remapping doesn't seem to take any effect anymore, confirmed by switching between those two artifacts (settings reset after every flashing), Haute42:
https://github.com/OpenStickCommunity/GP2040-CE/actions/runs/8395428102 - works
https://github.com/OpenStickCommunity/GP2040-CE/actions/runs/8395438843?pr=890 - doesn't
Could you take a look, please?

@arntsonl
Copy link
Contributor Author

arntsonl commented Apr 1, 2024

Keyboard keys remapping doesn't seem to take any effect anymore, confirmed by switching between those two artifacts (settings reset after every flashing), Haute42: https://github.com/OpenStickCommunity/GP2040-CE/actions/runs/8395428102 - works https://github.com/OpenStickCommunity/GP2040-CE/actions/runs/8395438843?pr=890 - doesn't Could you take a look, please?

We will look at this when we release the beta this week. Please don't run 'main' on a real device unless you are a developer.

@arntsonl arntsonl deleted the 20240217_inputauth_moved branch April 13, 2024 03:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants