Keyboard settings issue #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…part of the file anyway.
arntsonl
approved these changes
Apr 8, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix fetching/validating/saving of key mappings on settings page.
One issue was that we had nested forms. therefor the key mapping form was never submitted.
As there can be only one!
As quite a bit was being changed in the file so i decided to format the file according to .editorconfig.
I kept the formatting to one commit
The important commits are:
f4f0b88
a327f79
7fe3426
Important
When saving input mode "keyboard" validation will occur before saving, so if the validation fails the input mode wont be saved.
Alternative change would be to first save input mode then validate keymappings.
#928