Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard settings issue #947

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Keyboard settings issue #947

merged 8 commits into from
Apr 8, 2024

Commits on Apr 7, 2024

  1. This commit only contains formatting, as we will be touching a large … 

    …part of the file anyway.
    @Pelsin
    Pelsin committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    44ee9d3 View commit details
    Browse the repository at this point in the history

  2. Remove css warnings for unused props and setting correct classes

    @Pelsin
    Pelsin committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    9198c16 View commit details
    Browse the repository at this point in the history

  3. Fix all react render key warnings

    @Pelsin
    Pelsin committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    02db8df View commit details
    Browse the repository at this point in the history

  4. Remove unused prop that gives warnings

    @Pelsin
    Pelsin committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    6308ccd View commit details
    Browse the repository at this point in the history

  5. Fix mutation of baseButtonMappings values that is being used in setti… 

    …ngs page
    @Pelsin
    Pelsin committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    f4f0b88 View commit details
    Browse the repository at this point in the history

  6. Make sure validateMappings does not mutate and bleed over to other pages

    @Pelsin
    Pelsin committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    a327f79 View commit details
    Browse the repository at this point in the history

  7. Correctly fetch/save/validate keyMappings in settings

    @Pelsin
    Pelsin committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    7fe3426 View commit details
    Browse the repository at this point in the history

  8. Some more clean up of errors

    @Pelsin
    Pelsin committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    a673e4c View commit details
    Browse the repository at this point in the history